feat: add inferNamespacesFromPrivileges, default to true COMPASS-9572 (#7153)

* add inferNamespacesFromPrivileges, default to true

* Update packages/instance-model/lib/model.js

Co-authored-by: Copilot <[email protected]>

* cleanup

* use methods rather so the timing of keeping these synced is not a thing

* inferredFromPrivileges rather

* unit tests

* more might not

* tweak comment

---------

Co-authored-by: Copilot <[email protected]>

Author: lerouxb

package-lock.json

@@ -83,7 +83,7 @@ interface CollectionProps {
   sourceName: string | null;
   source: Collection;
   properties: { id: string; options?: Record<string, unknown> }[];
-  is_non_existent: boolean;
+  inferred_from_privileges: boolean;
 }
 
 type CollectionDataService = Pick<

packages/collection-model/index.d.ts

@@ -102,7 +102,7 @@ function pickCollectionInfo({
   validation,
   clustered,
   fle2,
-  is_non_existent,
+  inferred_from_privileges,
 }) {
   return {
     type,
@@ -113,7 +113,7 @@ function pickCollectionInfo({
     validation,
     clustered,
     fle2,
-    is_non_existent,
+    inferred_from_privileges,
   };
 }
 
@@ -134,8 +134,8 @@ const CollectionModel = AmpersandModel.extend(debounceActions(['fetch']), {
     status: { type: 'string', default: 'initial' },
     statusError: { type: 'string', default: null },
 
-    // Normalized values from collectionInfo command
-    is_non_existent: 'boolean',
+    // Normalized values from collectionInfo method
+    inferred_from_privileges: 'boolean',
     readonly: 'boolean',
     clustered: 'boolean',
     fle2: 'boolean',
@@ -269,7 +269,7 @@ const CollectionModel = AmpersandModel.extend(debounceActions(['fetch']), {
     const shouldFetchDbAndCollStats = getParentByType(
       this,
       'Instance'
-    ).shouldFetchDbAndCollStats;
+    ).shouldFetchDbAndCollStats();
 
     try {
       const newStatus = this.status === 'initial' ? 'fetching' : 'refreshing';
@@ -286,14 +286,14 @@ const CollectionModel = AmpersandModel.extend(debounceActions(['fetch']), {
         ...collStats,
         ...(collectionInfo && pickCollectionInfo(collectionInfo)),
       });
-      // If the collection is not unprovisioned `is_non_existent` anymore,
-      // let's update the parent database model to reflect the change.
-      // This happens when a user tries to insert first document into a
-      // collection that doesn't exist yet or creates a new collection
-      // for an unprovisioned database.
-      if (!this.is_non_existent) {
+      // If the collection is not `inferred_from_privileges` anymore, let's
+      // update the parent database model to reflect the change.  This happens
+      // when a user tries to insert first document into a collection that
+      // doesn't exist yet or creates a new collection for an unprovisioned
+      // database.
+      if (!this.inferred_from_privileges) {
         getParentByType(this, 'Database').set({
-          is_non_existent: false,
+          inferred_from_privileges: false,
         });
       }
     } catch (err) {
@@ -385,6 +385,11 @@ const CollectionCollection = AmpersandCollection.extend(
     async fetch({ dataService }) {
       const databaseName = getParentByType(this, 'Database')?.getId();
 
+      const shouldFetchNamespacesFromPrivileges = getParentByType(
+        this,
+        'Instance'
+      ).shouldFetchNamespacesFromPrivileges();
+
       if (!databaseName) {
         throw new Error(
           `Trying to fetch ${this.modelType} that doesn't have the Database parent model`
@@ -405,6 +410,7 @@ const CollectionCollection = AmpersandCollection.extend(
         {
           // Always fetch collections with info
           nameOnly: false,
+          fetchNamespacesFromPrivileges: shouldFetchNamespacesFromPrivileges,
           privileges: instanceModel.auth.privileges,
         }
       );

packages/collection-model/lib/model.js

@@ -286,6 +286,15 @@ export function createInstancesStore(
     }
   );
 
+  preferences.onPreferenceValueChanged('inferNamespacesFromPrivileges', () => {
+    const connectedConnectionIds = Array.from(
+      instancesManager.listMongoDBInstances().keys()
+    );
+    for (const connectionId of connectedConnectionIds) {
+      void refreshDatabases({ connectionId });
+    }
+  });
+
   on(connections, 'disconnected', function (connectionInfoId: string) {
     try {
       const instance =

packages/compass-app-stores/src/stores/instance-store.ts

@@ -24,7 +24,7 @@ type PluginTitleProps = {
 
 function PluginTitle({
   editViewName,
-  isNonExistent,
+  inferredFromPrivileges,
   isReadonly,
   isTimeSeries,
   sourceName,
@@ -68,12 +68,12 @@ function PluginTitle({
           ? 'Visibility'
           : collectionType === 'timeseries'
           ? 'TimeSeries'
-          : isNonExistent
+          : inferredFromPrivileges
           ? 'EmptyFolder'
           : 'Folder'
       }
       data-namespace={ns}
-      isNonExistent={isNonExistent}
+      inferredFromPrivileges={inferredFromPrivileges}
     />
   );
 }

packages/compass-collection/src/plugin-tab-title.tsx

@@ -138,7 +138,7 @@ const draggingTabStyles = css({
   cursor: 'grabbing !important',
 });
 
-const nonExistentStyles = css({
+const inferredFromPrivilegesStyles = css({
   color: palette.gray.base,
 });
 
@@ -184,7 +184,7 @@ export type WorkspaceTabPluginProps = {
   connectionName?: string;
   type: string;
   title: React.ReactNode;
-  isNonExistent?: boolean;
+  inferredFromPrivileges?: boolean;
   iconGlyph: GlyphName | 'Logo' | 'Server';
   tooltip?: [string, string][];
 };
@@ -206,7 +206,7 @@ function Tab({
   type,
   title,
   tooltip,
-  isNonExistent,
+  inferredFromPrivileges,
   isSelected,
   isDragging,
   onSelect,
@@ -271,7 +271,7 @@ function Tab({
           className={cx(
             tabStyles,
             themeClass,
-            isNonExistent && nonExistentStyles,
+            inferredFromPrivileges && inferredFromPrivilegesStyles,
             isSelected && selectedTabStyles,
             isSelected && tabTheme && selectedThemedTabStyles,
             isDragging && draggingTabStyles,

packages/compass-components/src/components/workspace-tabs/tab.tsx

@@ -43,7 +43,7 @@ const connections: Connection[] = [
         collectionsStatus: 'initial',
         collectionsLength: 5,
         collections: [],
-        isNonExistent: false,
+        inferredFromPrivileges: false,
       },
       {
         _id: 'db_ready',
@@ -57,26 +57,26 @@ const connections: Connection[] = [
             type: 'collection',
             sourceName: '',
             pipeline: [],
-            isNonExistent: false,
+            inferredFromPrivileges: false,
           },
           {
             _id: 'db_ready.woof',
             name: 'woof',
             type: 'timeseries',
             sourceName: '',
             pipeline: [],
-            isNonExistent: false,
+            inferredFromPrivileges: false,
           },
           {
             _id: 'db_ready.bwok',
             name: 'bwok',
             type: 'view',
             sourceName: '',
             pipeline: [],
-            isNonExistent: false,
+            inferredFromPrivileges: false,
           },
         ],
-        isNonExistent: false,
+        inferredFromPrivileges: false,
       },
     ],
     isReady: true,

packages/compass-connections-navigation/src/connections-navigation-tree.spec.tsx

@@ -5,8 +5,8 @@ import type { GlyphName } from '@mongodb-js/compass-components';
 import { WithStatusMarker } from './with-status-marker';
 import { isLocalhost } from 'mongodb-build-info';
 
-const NON_EXISTANT_NAMESPACE_TEXT =
-  'Your privileges grant you access to this namespace, but it does not currently exist';
+const INFERRED_FROM_PRIVILEGES_TEXT =
+  'Your privileges grant you access to this namespace, but it might not currently exist';
 
 const tooltipTriggerStyles = css({
   display: 'flex',
@@ -35,21 +35,21 @@ const IconWithTooltip = ({
 
 export const NavigationItemIcon = ({ item }: { item: SidebarTreeItem }) => {
   if (item.type === 'database') {
-    if (item.isNonExistent) {
+    if (item.inferredFromPrivileges) {
       return (
         <IconWithTooltip
-          text={NON_EXISTANT_NAMESPACE_TEXT}
+          text={INFERRED_FROM_PRIVILEGES_TEXT}
           glyph="EmptyDatabase"
         />
       );
     }
     return <Icon glyph="Database" />;
   }
   if (item.type === 'collection') {
-    if (item.isNonExistent) {
+    if (item.inferredFromPrivileges) {
       return (
         <IconWithTooltip
-          text={NON_EXISTANT_NAMESPACE_TEXT}
+          text={INFERRED_FROM_PRIVILEGES_TEXT}
           glyph="EmptyFolder"
         />
       );