fixup! Clean up "Actions" generic types

Remove unwanted type parameter defaults

Author: kraenhansen

packages/compass-components/src/components/actions/item-action-button.tsx

@@ -5,7 +5,7 @@ import { ItemActionButtonSize } from './constants';
 import type { ItemComponentProps } from './types';
 import { SmallIconButton } from './small-icon-button';
 
-export function ItemActionButton({
+export function ItemActionButton<Action extends string>({
   action,
   icon = <></>,
   label,
@@ -17,7 +17,7 @@ export function ItemActionButton({
   iconStyle,
   isDisabled,
   'data-testid': dataTestId,
-}: ItemComponentProps) {
+}: ItemComponentProps<Action>) {
   return (
     <SmallIconButton
       key={action}

packages/compass-components/src/components/actions/item-action-controls.tsx

@@ -33,7 +33,7 @@ export type ItemActionControlsProps<Action extends string> = {
   'data-testid'?: string;
 };
 
-export function ItemActionControls<Action extends string = string>({
+export function ItemActionControls<Action extends string>({
   isVisible = true,
   actions,
   onAction,

packages/compass-components/src/components/actions/types.ts

@@ -2,7 +2,7 @@ import type { glyphs } from '@leafygreen-ui/icon';
 
 import type { ItemActionButtonSize } from './constants';
 
-export type ItemBase<Action extends string = string> = {
+export type ItemBase<Action extends string> = {
   action: Action;
   label: string;
   icon?: React.ReactChild;
@@ -18,7 +18,7 @@ export type ItemBase<Action extends string = string> = {
   expandedAs?: React.ComponentType<ItemComponentProps<Action>>;
 };
 
-export type ItemComponentProps<Action extends string = string> = Omit<
+export type ItemComponentProps<Action extends string> = Omit<
   ItemBase<Action>,
   'expandedAs'
 > & {
@@ -31,7 +31,7 @@ export type ItemComponentProps<Action extends string = string> = Omit<
   setHidable?(hidable: boolean): void;
 };
 
-export type ItemAction<Action extends string = string> = {
+export type ItemAction<Action extends string> = {
   icon: keyof typeof glyphs | React.ReactElement;
 } & ItemBase<Action>;
 

packages/compass-connections-navigation/src/connect-button.tsx

@@ -35,7 +35,7 @@ function ConnectMenuItem({ action, glyph, ...rest }: ConnectMenuItemProps) {
 // Hack to make SplitButton consider this as a MenuItem
 ConnectMenuItem.displayName = 'MenuItem';
 
-type ConnectButtonProps = ItemComponentProps;
+type ConnectButtonProps = ItemComponentProps<Actions>;
 
 export function ConnectButton({
   setHidable,