Skip to content

Commit 6672d76

Browse files
authored
feat(components, data-modeling): add portal version of the Drawer component; use new DrawerSection in data-modeling COMPASS-9610 (#7138)
* feat(components, data-modeling): add portal version of the Drawer component; use new DrawerSection in data-modeling * chore(components): add order prop * chore(data-modeling): remove extra padding; adjust tests * chore(data-modeling): temporarily skip unit tests in electron runtime
1 parent c2e5f6a commit 6672d76

File tree

11 files changed

+399
-84
lines changed

11 files changed

+399
-84
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/compass-components/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@
9191
"mongodb-query-util": "^2.5.3",
9292
"polished": "^4.2.2",
9393
"react": "^17.0.2",
94+
"react-dom": "^17.0.2",
9495
"react-hotkeys-hook": "^4.3.7",
9596
"react-intersection-observer": "^8.34.0",
9697
"react-virtualized-auto-sizer": "^1.0.6",
@@ -110,7 +111,6 @@
110111
"chai": "^4.3.4",
111112
"mocha": "^10.2.0",
112113
"nyc": "^15.1.0",
113-
"react-dom": "^17.0.2",
114114
"sinon": "^9.0.0",
115115
"typescript": "^5.8.3"
116116
},

packages/compass-components/src/components/compass-components-provider.tsx

Lines changed: 29 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import { SignalHooksProvider } from './signal-popover';
77
import { RequiredURLSearchParamsProvider } from './links/link';
88
import { StackedComponentProvider } from '../hooks/use-stacked-component';
99
import { ContextMenuProvider } from './context-menu';
10+
import { DrawerContentProvider } from './drawer-portal';
1011

1112
type GuideCueProviderProps = React.ComponentProps<typeof GuideCueProvider>;
1213

@@ -131,33 +132,35 @@ export const CompassComponentsProvider = ({
131132
darkMode={darkMode}
132133
popoverPortalContainer={popoverPortalContainer}
133134
>
134-
<StackedComponentProvider zIndex={stackedElementsZIndex}>
135-
<RequiredURLSearchParamsProvider
136-
utmSource={utmSource}
137-
utmMedium={utmMedium}
138-
>
139-
<GuideCueProvider
140-
onNext={onNextGuideGue}
141-
onNextGroup={onNextGuideCueGroup}
135+
<DrawerContentProvider>
136+
<StackedComponentProvider zIndex={stackedElementsZIndex}>
137+
<RequiredURLSearchParamsProvider
138+
utmSource={utmSource}
139+
utmMedium={utmMedium}
142140
>
143-
<SignalHooksProvider {...signalHooksProviderProps}>
144-
<ConfirmationModalArea>
145-
<ContextMenuProvider disabled={disableContextMenus}>
146-
<ToastArea>
147-
{typeof children === 'function'
148-
? children({
149-
darkMode,
150-
portalContainerRef: setPortalContainer,
151-
scrollContainerRef: setScrollContainer,
152-
})
153-
: children}
154-
</ToastArea>
155-
</ContextMenuProvider>
156-
</ConfirmationModalArea>
157-
</SignalHooksProvider>
158-
</GuideCueProvider>
159-
</RequiredURLSearchParamsProvider>
160-
</StackedComponentProvider>
141+
<GuideCueProvider
142+
onNext={onNextGuideGue}
143+
onNextGroup={onNextGuideCueGroup}
144+
>
145+
<SignalHooksProvider {...signalHooksProviderProps}>
146+
<ConfirmationModalArea>
147+
<ContextMenuProvider disabled={disableContextMenus}>
148+
<ToastArea>
149+
{typeof children === 'function'
150+
? children({
151+
darkMode,
152+
portalContainerRef: setPortalContainer,
153+
scrollContainerRef: setScrollContainer,
154+
})
155+
: children}
156+
</ToastArea>
157+
</ContextMenuProvider>
158+
</ConfirmationModalArea>
159+
</SignalHooksProvider>
160+
</GuideCueProvider>
161+
</RequiredURLSearchParamsProvider>
162+
</StackedComponentProvider>
163+
</DrawerContentProvider>
161164
</LeafyGreenProvider>
162165
);
163166
};

0 commit comments

Comments
 (0)