fix hook issue

Author: DarshanaVenkatesh

packages/compass-aggregations/src/components/stage-toolbar/stage-operator-select.tsx

@@ -100,13 +100,19 @@ export const StageOperatorSelect = ({
   collectionStats,
   stages,
 }: StageOperatorSelectProps) => {
+  const enableAtlasSearchIndexes = usePreference('enableAtlasSearchIndexes');
+  // filter out search stages for data explorer
+  const filteredStages =
+    isReadonlyView && enableAtlasSearchIndexes
+      ? stages
+      : stages.filter((stage) => !isSearchStage(stage.name));
+
   const onStageOperatorSelected = useCallback(
     (name: string | null) => {
       onChange(index, name);
     },
     [onChange, index]
   );
-
   const versionIncompatibleCompass =
     !VIEW_PIPELINE_UTILS.isVersionSearchCompatibleForViewsCompass(
       serverVersion
@@ -132,7 +138,7 @@ export const StageOperatorSelect = ({
       data-testid="stage-operator-combobox"
       className={comboboxStyles}
     >
-      {stages.map((stage: Stage, index) => (
+      {filteredStages.map((stage: Stage, index) => (
         <ComboboxOption
           data-testid={`combobox-option-stage-${stage.name}`}
           key={`combobox-option-stage-${index}`}
@@ -174,7 +180,6 @@ export default withPreferences(
         isTimeSeries: state.isTimeSeries,
         sourceName: state.sourceName,
         preferencesReadOnly: ownProps.readOnly,
-        enableAtlasSearchIndexes: usePreference('enableAtlasSearchIndexes'),
       });
       return {
         selectedStage: stage.stageOperator,

packages/compass-aggregations/src/utils/stage.ts

@@ -47,14 +47,12 @@ export const filterStageOperators = ({
   isTimeSeries,
   sourceName,
   preferencesReadOnly,
-  enableAtlasSearchIndexes,
 }: {
   serverVersion: string;
   env: ServerEnvironment;
   isTimeSeries: boolean;
   sourceName: string | null;
   preferencesReadOnly: boolean;
-  enableAtlasSearchIndexes: boolean;
 }): FilteredStageOperators => {
   const namespaceType = isTimeSeries
     ? TIME_SERIES
@@ -68,7 +66,6 @@ export const filterStageOperators = ({
     env,
     namespaceType,
     preferencesReadOnly,
-    enableAtlasSearchIndexes,
   });
 
   if (FilteredStagesCache.has(cacheKey)) {
@@ -88,14 +85,9 @@ export const filterStageOperators = ({
             [env, ATLAS]
           : env,
     },
-  })
-    .filter((op) => {
-      return disallowOutputStagesOnCompassReadonly(op, preferencesReadOnly);
-    })
-    .filter((op) => {
-      // if enableAtlasSearchIndexes is false, only allow non search stages
-      return enableAtlasSearchIndexes || !isSearchStage(op.value);
-    });
+  }).filter((op) => {
+    return disallowOutputStagesOnCompassReadonly(op, preferencesReadOnly);
+  });
 
   FilteredStagesCache.set(cacheKey, filteredStages);