Skip to content

Commit 9efe630

Browse files
committed
fixup: diagramming dev dep for sinon mock
1 parent 83f5c04 commit 9efe630

File tree

3 files changed

+9
-264
lines changed

3 files changed

+9
-264
lines changed

package-lock.json

Lines changed: 1 addition & 259 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/compass-data-modeling/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@
6363
"@mongodb-js/compass-user-data": "^0.9.0",
6464
"@mongodb-js/compass-utils": "^0.9.10",
6565
"@mongodb-js/compass-workspaces": "^0.51.0",
66-
"@mongodb-js/diagramming": "^1.3.3",
6766
"bson": "^6.10.4",
6867
"compass-preferences-model": "^2.50.0",
6968
"html-to-image": "1.11.11",
@@ -78,6 +77,7 @@
7877
"redux-thunk": "^2.4.2"
7978
},
8079
"devDependencies": {
80+
"@mongodb-js/diagramming": "^1.3.3",
8181
"@mongodb-js/eslint-config-compass": "^1.4.6",
8282
"@mongodb-js/mocha-config-compass": "^1.7.0",
8383
"@mongodb-js/prettier-config-compass": "^1.2.8",

packages/compass-data-modeling/src/components/diagram-editor.spec.tsx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import type {
1111
Edit,
1212
MongoDBDataModelDescription,
1313
} from '../services/data-model-storage';
14-
import compassComponents from '@mongodb-js/compass-components';
14+
import diagramming from '@mongodb-js/diagramming';
1515
import sinon from 'sinon';
1616
import { DiagramProvider } from '@mongodb-js/compass-components';
1717
import { DataModelingWorkspaceTab } from '..';
@@ -156,13 +156,16 @@ describe('DiagramEditor', function () {
156156
let store: DataModelingStore;
157157

158158
before(function () {
159-
// We need to tub the Diagram import because it has problems with ESM/CJS interop
160-
sinon.stub(compassComponents, 'Diagram').callsFake(mockDiagramming.Diagram);
159+
sinon.stub(diagramming, 'Diagram').callsFake(mockDiagramming.Diagram);
161160
sinon
162-
.stub(compassComponents, 'applyLayout')
161+
.stub(diagramming, 'applyLayout')
163162
.callsFake(mockDiagramming.applyLayout as any);
164163
});
165164

165+
after(function () {
166+
sinon.restore();
167+
});
168+
166169
context('with existing diagram', function () {
167170
beforeEach(async function () {
168171
const result = renderDiagramEditor({

0 commit comments

Comments
 (0)