chore: move scrollTo to jsdom-extra-mocks-register

Author: gagik

configs/mocha-config-compass/register/jsdom-extra-mocks-register.js

@@ -51,3 +51,6 @@ globalThis.CustomEvent = window.CustomEvent;
 globalThis.Event = window.Event;
 globalThis.Blob = window.Blob;
 globalThis.File = window.File;
+
+// jsdom doesn't support scrollTo on the Element, so make it a no-op
+globalThis.Element.prototype.scrollTo = () => {};

configs/webpack-config-compass/src/index.ts

@@ -279,7 +279,23 @@ export function createElectronRendererConfig(
               overlay:
                 process.env.DISABLE_DEVSERVER_OVERLAY === 'true'
                   ? false
-                  : { warnings: false, errors: true, runtimeErrors: true },
+                  : {
+                      runtimeErrors: (error) => {
+                        // ResizeObserver errors are harmless and expected in some cases.
+                        // We currently get them when opening the Assistant drawer.
+                        if (
+                          error?.message ===
+                          'ResizeObserver loop completed with undelivered notifications.'
+                        ) {
+                          // eslint-disable-next-line no-console
+                          console.warn(error);
+                          return false;
+                        }
+                        return true;
+                      },
+                      errors: true,
+                      warnings: false,
+                    },
             },
             https: false,
             hot: opts.hot,

packages/compass-assistant/src/assistant-chat.spec.tsx

@@ -7,12 +7,10 @@ import {
 } from '@mongodb-js/testing-library-compass';
 import { AssistantChat } from './assistant-chat';
 import { expect } from 'chai';
-import { createMockChat, withMockedScrollTo } from '../test/utils';
+import { createMockChat } from '../test/utils';
 import type { AssistantMessage } from './compass-assistant-provider';
 
 describe('AssistantChat', function () {
-  withMockedScrollTo();
-
   let originalScrollTo: typeof Element.prototype.scrollTo;
   // Mock scrollTo method for DOM elements to prevent test failures
   before(function () {

packages/compass-assistant/src/compass-assistant-provider.spec.tsx

@@ -22,7 +22,7 @@ import {
 } from '@mongodb-js/compass-components';
 import type { AtlasService } from '@mongodb-js/atlas-service/provider';
 import { CompassAssistantDrawer } from './compass-assistant-drawer';
-import { createMockChat, withMockedScrollTo } from '../test/utils';
+import { createMockChat } from '../test/utils';
 
 // Test component that renders AssistantProvider with children
 const TestComponent: React.FunctionComponent<{
@@ -85,7 +85,6 @@ describe('AssistantProvider', function () {
   });
 
   describe('with existing chat instance', function () {
-    withMockedScrollTo();
     before(function () {
       // TODO(COMPASS-9618): skip in electron runtime for now, drawer has issues rendering
       if ((process as any).type === 'renderer') {

packages/compass-assistant/test/utils.tsx

@@ -15,17 +15,3 @@ export const createMockChat = ({
     sendMessage: sinon.SinonStub;
   };
 };
-
-export function withMockedScrollTo() {
-  let originalScrollTo: typeof Element.prototype.scrollTo;
-  // Mock scrollTo method for DOM elements to prevent test failures
-  before(function () {
-    originalScrollTo = Element.prototype.scrollTo;
-    if (!Element.prototype.scrollTo) {
-      Element.prototype.scrollTo = () => {};
-    }
-  });
-  after(function () {
-    Element.prototype.scrollTo = originalScrollTo;
-  });
-}