stricter typing for type param and fix update tests

Author: myang1220

packages/compass-user-data/src/user-data.spec.ts

@@ -440,7 +440,7 @@ describe('AtlasUserData', function () {
     validatorOpts: ValidatorOptions = {},
     orgId = 'test-org',
     groupId = 'test-group',
-    type = 'favorites'
+    type: 'favorites' | 'recents' | 'pipelines' = 'favorites'
   ) => {
     return new AtlasUserData(
       getTestSchema(validatorOpts),
@@ -613,7 +613,7 @@ describe('AtlasUserData', function () {
       const result = await userData.readAll();
 
       expect(result.data).to.have.lengthOf(0);
-      expect(result.errors).to.have.lengthOf(0);
+      expect(result.errors).to.have.lengthOf(1);
     });
 
     it('handles errors gracefully', async function () {
@@ -703,11 +703,7 @@ describe('AtlasUserData', function () {
         hasDarkMode: false,
       });
 
-      expect(result).to.deep.equal({
-        ...defaultValues(),
-        name: 'Updated Name',
-        hasDarkMode: false,
-      });
+      expect(result).equals(true);
 
       expect(authenticatedFetchStub).to.have.been.calledOnce;
       const [url, options] = authenticatedFetchStub.firstCall.args;
@@ -718,18 +714,15 @@ describe('AtlasUserData', function () {
       expect(options.headers['Content-Type']).to.equal('application/json');
     });
 
-    it('throws error when response is not ok', async function () {
+    it('returns false when response is not ok', async function () {
       authenticatedFetchStub.resolves(mockResponse({}, false, 400));
 
       const userData = getAtlasUserData();
 
-      try {
-        await userData.updateAttributes('test-id', { name: 'Updated' });
-        expect.fail('Should have thrown error');
-      } catch (error) {
-        expect(error).to.be.instanceOf(Error);
-        expect((error as Error).message).to.contain('Failed to update data');
-      }
+      const result = await userData.updateAttributes('test-id', {
+        name: 'Updated',
+      });
+      expect(result).equals(false);
     });
 
     it('uses custom serializer for request body', async function () {
@@ -807,12 +800,12 @@ describe('AtlasUserData', function () {
     it('constructs URL correctly for different types', async function () {
       authenticatedFetchStub.resolves(mockResponse({}));
 
-      const userData = getAtlasUserData({}, 'org123', 'group456', 'recent');
+      const userData = getAtlasUserData({}, 'org123', 'group456', 'recents');
       await userData.write('item789', { name: 'Recent Item' });
 
       const [url] = authenticatedFetchStub.firstCall.args;
       expect(url).to.equal(
-        'cluster-connection.cloud-local.mongodb.com/recent/org123/group456'
+        'cluster-connection.cloud-local.mongodb.com/recents/org123/group456'
       );
     });
   });

packages/compass-user-data/src/user-data.ts

@@ -342,7 +342,7 @@ export class AtlasUserData<T extends z.Schema> extends IUserData<T> {
   private readonly authenticatedFetch;
   private orgId: string = '';
   private groupId: string = '';
-  private readonly type: string;
+  private readonly type: 'recents' | 'favorites' | 'pipelines';
   private readonly BASE_URL = 'cluster-connection.cloud-local.mongodb.com';
   constructor(
     validator: T,
@@ -352,7 +352,7 @@ export class AtlasUserData<T extends z.Schema> extends IUserData<T> {
     ) => Promise<Response>,
     orgId: string,
     groupId: string,
-    type: string,
+    type: 'recents' | 'favorites' | 'pipelines',
     { serialize, deserialize }: AtlasUserDataOptions<z.input<T>>
   ) {
     super(validator, { serialize, deserialize });
@@ -426,40 +426,33 @@ export class AtlasUserData<T extends z.Schema> extends IUserData<T> {
   }
 
   async readAll(): Promise<ReadAllResult<T>> {
-    const response = await this.authenticatedFetch(this.getUrl(), {
-      method: 'GET',
-    });
     const result: ReadAllResult<T> = {
       data: [],
       errors: [],
     };
-    if (!response.ok) {
-      log.error(
-        mongoLogId(1_001_000_364),
-        'Atlas Backend',
-        'Error reading data',
-        {
-          url: this.getUrl(),
-          error: `Status ${response.status} ${response.statusText}`,
-        }
-      );
-      result.errors.push(
-        new Error(
+    try {
+      const response = await this.authenticatedFetch(this.getUrl(), {
+        method: 'GET',
+      });
+      if (!response.ok) {
+        throw new Error(
           `Failed to get data: ${response.status} ${response.statusText}`
-        )
-      );
-      return result;
-    }
-    const json = await response.json();
-    for (const item of json) {
-      try {
-        const parsedData = this.deserialize(item.data as string);
-        result.data.push(this.validator.parse(parsedData) as z.output<T>);
-      } catch (error) {
-        result.errors.push(error as Error);
+        );
+      }
+      const json = await response.json();
+      for (const item of json) {
+        try {
+          const parsedData = this.deserialize(item.data as string);
+          result.data.push(this.validator.parse(parsedData) as z.output<T>);
+        } catch (error) {
+          result.errors.push(error as Error);
+        }
       }
+      return result;
+    } catch (error) {
+      result.errors.push(error as Error);
+      return result;
     }
-    return result;
   }
 
   async updateAttributes(
@@ -482,7 +475,7 @@ export class AtlasUserData<T extends z.Schema> extends IUserData<T> {
       return true;
     } catch (error) {
       log.error(
-        mongoLogId(1_001_000_365),
+        mongoLogId(1_001_000_364),
         'Atlas Backend',
         'Error updating data',
         {