chore(deps): update node-gyp to 10; remove workaround for windows; remove python 3.6 from path COMPASS-8346 #6390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move python 3.6 from path
gribnoysup
commented
Oct 23, 2024
| pathsToPrepend.unshift('/opt/mongodbtoolchain/v3/bin'); | ||
|
|
||
| // Make sure that linux is using python 3.6 (node-gyp requirement) | ||
| pathsToPrepend.unshift('/opt/python/3.6/bin'); |
Collaborator
Author
There was a problem hiding this comment.
Seems like mongodbtoolchain is coming with 3.9 that works for node-gyp@10, so I just dropped the /opt/python from paths, tell me if you think it's a bad idea and we should be more explicit about it
gribnoysup
commented
Oct 23, 2024
Comment on lines
-16
to
-19
| # For actually resolving the bug, we would probably need somebody with a local | ||
| # reproduction. However, it seems likely that other people will also encounter | ||
| # this issue, so there's also a good chance that this workaround will just | ||
| # not be needed with a future node-gyp version. |
Collaborator
Author
There was a problem hiding this comment.
node-gyp worked on windows without this script, so I'm assuming that it's not needed anymore
addaleax
approved these changes
Oct 23, 2024
gribnoysup
changed the title
gagik
approved these changes
Oct 23, 2024
Collaborator
Author
|
Macos arm was super backlogged, tests are running now, but I don't think I'll wait until they're done, enough tests has passed to confirm the fix I feel like, will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates node-gyp to latest to make sure that it works on platforms where python 3.12 is installed by default. I did a few manual evergreen runs (ubuntu, other platforms) to confirm that it passes on all platforms