chore(compass-components): less document whitespace #6439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
the
no-title-validation
kraenhansen
force-pushed
the
kh/less-document-whitespace
branch
from
011766f to
3bc5471
Compare
Anemy
approved these changes
Nov 4, 2024
| }); | ||
|
|
||
| const expandButton = css({ | ||
| '& > div:has(svg)': { |
Member
There was a problem hiding this comment.
This does feel brittle, if something changes in how leafygreen orientates their buttons internally this could start looking different. Not sure if there's a better way to do this though, looking at the docs I don't think this is exposed for folks. Looks fine, mostly calling it out in case there's a way anyone else knows of, and also something we can watch out for when updating leafygreen deps.
Contributor
Author
There was a problem hiding this comment.
Yeah - I agree this is brittle. I should have made that more obvious in my PR: I've proposed a change to LG to upstream this mongodb/leafygreen-ui#2535.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a preparation for COMPASS-4635 this solves the first part of the designed proposed in EXPO-2098: Making the expand-all button more compact and trimming padding.
Compact expand-all button
Less padding on the left side of the trash button and between the "+" and the "▶"
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes