feat(compass-generative-ai): Add plugin to generative ai package to show opt-in for project setting in DE COMPASS-8378 #6489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
reviewed
Nov 13, 2024
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/store/atlas-optin-reducer.ts
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/store/atlas-optin-reducer.ts
Outdated
Show resolved
Hide resolved
Anemy
reviewed
Nov 13, 2024
Member
Anemy
left a comment
Anemy
left a comment
There was a problem hiding this comment.
Looking good, left a couple suggestions.
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/components/ai-signin-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/store/atlas-optin-reducer.ts
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/store/atlas-optin-reducer.ts
Outdated
Show resolved
Hide resolved
Anemy
reviewed
Nov 14, 2024
gribnoysup
reviewed
Nov 14, 2024
Anemy
reviewed
Nov 17, 2024
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/store/atlas-optin-reducer.ts
Outdated
Show resolved
Hide resolved
Anemy
reviewed
Nov 18, 2024
packages/compass-generative-ai/src/store/atlas-optin-reducer.ts
Outdated
Show resolved
Hide resolved
Anemy
reviewed
Nov 18, 2024
Member
Anemy
left a comment
Anemy
left a comment
There was a problem hiding this comment.
Looking good! Left a couple suggestions
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
Anemy
reviewed
Nov 20, 2024
Member
Anemy
left a comment
Anemy
left a comment
There was a problem hiding this comment.
Nice! Looking good, left a couple suggestions. I think we're almost there!
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
Anemy
reviewed
Nov 21, 2024
Member
Anemy
left a comment
Anemy
left a comment
There was a problem hiding this comment.
Nice, one small tweak. Trying it out now
packages/compass-generative-ai/src/components/ai-optin-modal.spec.tsx
Outdated
Show resolved
Hide resolved
Anemy
approved these changes
Nov 21, 2024
Member
Anemy
left a comment
Anemy
left a comment
There was a problem hiding this comment.
Wahoo! Looks good. Left 2 small suggestions, not blockers. Nice work
Anemy
approved these changes
Nov 21, 2024
Anemy
reviewed
Nov 22, 2024
packages/compass-generative-ai/src/components/ai-optin-modal.tsx
Outdated
Show resolved
Hide resolved
Anemy
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the compass-generative-ai package to have a plugin used in CompassWeb to show the opt-in modal. This opt-in modal, when a user clicks to enable it, calls to set the setting on the backend when clicked. Change the current sign in flow to only show the sign in flow if a user isn’t already authenticated.
This is a user setting.
More info in the tech design: https://docs.google.com/document/d/1to8ghEzI600WxQm08T5nzNfFLkeLDx55EtYxDb4Lvno/edit#bookmark=id.d6b8bffb4
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes