chore(atlas-service): update atlas service sign in naming COMPASS-8493 #6544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
changed the title
lerouxb
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-8493
No functional changes.
Removes the SignInPrompt and adds and explicit
mainProcessSignInboolean to indicate for the Atlas auth service to use ipc to sign in in the main process. It probably makes sense to remove the recursive sign in call here that happens in the store to streamline it, I'm thinking it's not worth doing now. Once we have a reason to change it we can do some more cleanup. The changes here at least should make the intention more transparent.