chore(deps): update leafygreen packages to latest #6555
Conversation
| const idx = row * colCount + col; | ||
| return ( | ||
| <div | ||
| key={idx} |
| className: confirmationProps.hideCancelButton | ||
| ? hideButtonStyles | ||
| : undefined, | ||
| children: confirmationProps.cancelButtonText ?? 'Cancel', |
There was a problem hiding this comment.
button text is always Cancel and LG removed this option. https://www.mongodb.design/component/confirmation-modal/code-docs
| npm ci | ||
| - name: Bump packages | ||
| run: | | ||
| npm add $(cat packages/compass-components/package.json | jq -r '.dependencies | keys[]' | grep "@leafygreen-ui" | sed s/$/@latest/ | xargs) --workspace=@mongodb-js/compass-components |
There was a problem hiding this comment.
There was a problem hiding this comment.
now i am thinking about jq - would it be available on CI 🤔 ?
There was a problem hiding this comment.
and its available there: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#tools
| @@ -0,0 +1,54 @@ | |||
| name: Update leafygreen packages | |||
There was a problem hiding this comment.
this whole file is a copy of update-electron with lg changes
| // Exporting this for test only to stub it and set | ||
| // its value. This enables to test cancelShardingaction. | ||
| export const showConfirmation = showConfirmationModal; | ||
| export const showConfirmation: typeof showConfirmationModal = |
There was a problem hiding this comment.
I'm curious as to why this is needed? 🤔 It seems redundant to me.
Same with the change in packages/compass-indexes/src/modules/regular-indexes.ts and packages/compass-indexes/src/modules/search-indexes.ts
There was a problem hiding this comment.
ts started to complain about this
The inferred type of 'showConfirmation' cannot be named without a reference to '@mongodb-js/compass-components/node_modules/@leafygreen-ui/confirmation-modal'. This is likely not portable. A type annotation is necessary.ts(2742).
I'll close this PR as I split the removal of combobox from this.
Currently draft because i need to check update for
@emotion/cssAnd also popover v12 changes.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes