chore(combobox): remove combobox clone COMPASS-6465 #6562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
approved these changes
Dec 12, 2024
| /> | ||
| ))} | ||
| </Combobox> | ||
| <React.Fragment> |
Contributor
There was a problem hiding this comment.
As far as I can tell, this would be the first of its kind in the codebase.
I suggest using the shorthand:
Suggested change
| <React.Fragment> | |
| <> |
Collaborator
Author
There was a problem hiding this comment.
We are already using it at other places, but probably as Fragment and not React.Fragment.
Collaborator
Author
There was a problem hiding this comment.
actually there are instances of both in the codebase, not many but they do exist.
Contributor
There was a problem hiding this comment.
I put in a bit more effort and for what it's worth: I see two occurrences of <React.Fragment>, three of <Fragment> and 183 <> 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove clone of LG Combobox and directly use it.
UX changes:
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes