chore: gha workflow updates #6591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
commented
Jan 7, 2025
| with: | ||
| # don't checkout a detatched HEAD | ||
| ref: ${{ github.head_ref }} | ||
| token: ${{ steps.app-token.outputs.token }} |
Collaborator
Author
There was a problem hiding this comment.
The changes to this workflow are an attempt to disassociate @himanshusinghs from the generated commit.
nirinchev
commented
Jan 7, 2025
| - name: Start Release | ||
| env: | ||
| JIRA_API_TOKEN: ${{ secrets.JIRA_API_TOKEN }} |
Collaborator
Author
There was a problem hiding this comment.
This secret doesn't seem to exist and it's not used anywhere.
gribnoysup
approved these changes
Jan 7, 2025
Collaborator
There was a problem hiding this comment.
Good change! Seems like we have something in our precommit hook logic though preventing this from being done automatically, probably worth a ticket 🤔
mabaasit
approved these changes
Jan 7, 2025
nirinchev
added
the
no-title-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This cleans up a few gha workflows:
Motivation and Context
Types of changes