Skip to content

fix(e2e-tests): close the focus-mode modal COMPASS-8820 #6615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 16, 2025
+1 −12
Merged

fix(e2e-tests): close the focus-mode modal COMPASS-8820 #6615

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80185d5
close the modal
mabaasit Jan 14, 2025
97fd4c0
close modal using close button
mabaasit Jan 15, 2025
e0ffd57
remove unused stuff
mabaasit Jan 15, 2025
b5486be
Merge branch 'main' into flakes-fix
mabaasit Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions packages/compass-e2e-tests/tests/collection-aggregations-tab.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,11 @@ import {
createNumbersCollection,
} from '../helpers/insert-data';
import { saveAggregationPipeline } from '../helpers/commands/save-aggregation-pipeline';
import { Key } from 'webdriverio';
import type { ChainablePromiseElement } from 'webdriverio';
import { switchPipelineMode } from '../helpers/commands/switch-pipeline-mode';

const { expect } = chai;

function sleep(ms: number) {
return new Promise((resolve) => setTimeout(resolve, ms));
}

const OUT_STAGE_PREVIEW_TEXT =
'The $out operator will cause the pipeline to persist the results to the specified location (collection, S3, or Atlas). If the collection exists it will be replaced.';
const MERGE_STAGE_PREVIEW_TEXT =
Expand Down Expand Up @@ -1332,13 +1327,7 @@ describe('Collection aggregations tab', function () {
});
await browser.waitForAriaDisabled(previousButton, true);

// previousButton has a tooltip, to close it we press Escape
// and wait a bit (for the debounced close to kick in)
await browser.keys([Key.Escape]);
await sleep(50);

// the next Escape is for the modal to close
await browser.keys([Key.Escape]);
await browser.clickVisible(Selectors.FocusModeCloseModalButton);

await modal.waitForDisplayed({ reverse: true });
});
Expand Down
Loading