fix(package-lock): downgrade puppeteer-core to align with version required by webdriverio #6644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currenly an ELSPROBLEMS error on main caused by the version of puppeteer-core being mismatched with the one specified by webdriver:
This patch is a fix for that and for the ci task that's supposed to be checking that. When I added it initially, I forgot to actually exit with a non-zero code there so that it actually fails the task 🤦
EDIT: so initially I tried downgrading, but we actually depend on puppeteer-core@23 so that firefox installation works, so instead of downgrading, I'm overriding the dependency version in webdriverio to allow installing it without ELSPROBLEMS errors, the steps are not straightforward to actually make that happen so I'll document them here for posterity:
this makes sure that overrides applies to the package-lock record for the package
if the order is switched, webdriverio installation will fail because npm first does the version check and only then applies overrides