Skip to content

chore: setup auto-update when testing auto-update, even in CI. #6651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025
Merged

chore: setup auto-update when testing auto-update, even in CI. #6651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/compass-e2e-tests/helpers/compass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,8 +636,10 @@ async function startCompassElectron(

process.env.APP_ENV = 'webdriverio';
// For webdriverio env we are changing appName so that keychain records do not
// overlap with anything else
process.env.HADRON_PRODUCT_NAME_OVERRIDE = 'MongoDB Compass WebdriverIO';
// overlap with anything else. But leave it alone when testing auto-update.
if (!process.env.HADRON_AUTO_UPDATE_ENDPOINT_OVERRIDE) {
process.env.HADRON_PRODUCT_NAME_OVERRIDE = 'MongoDB Compass WebdriverIO';
}

// Guide cues might affect too many tests in a way where the auto showing of the cue prevents
// clicks from working on elements. Dealing with this case-by-case is way too much work, so
Expand Down
4 changes: 1 addition & 3 deletions packages/compass/src/main/application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,7 @@ class CompassApplication {

await this.setupCORSBypass();
void this.setupCompassAuthService();
// TODO(COMPASS-7618): For now don't setup auto-update in CI because the
// toasts will obscure other things which we don't expect yet.
if (!process.env.CI) {
if (!process.env.CI || process.env.HADRON_AUTO_UPDATE_ENDPOINT_OVERRIDE) {
this.setupAutoUpdate();
}
await setupCSFLELibrary();
Expand Down
Loading