feat(databases-collections): handle non-existent namespaces COMPASS-5750 #6664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabaasit
changed the title
mabaasit
commented
Jan 29, 2025
Comment on lines
+255
to
+264
| // If the collection is not unprovisioned `is_non_existent` anymore, | ||
| // let's update the parent database model to reflect the change. | ||
| // This happens when a user tries to insert first document into a | ||
| // collection that doesn't exist yet or creates a new collection | ||
| // for an unprovisioned database. | ||
| if (!this.is_non_existent) { | ||
| getParentByType(this, 'Database').set({ | ||
| is_non_existent: false, | ||
| }); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Not sure if this is the right place for this, but if you feel it does not belong here, let me know
mabaasit
commented
Jan 30, 2025
Comment on lines
812
to
+817
| void dispatch(fetchCollectionInfo(workspaceOptions)); | ||
| } | ||
|
|
||
| if (workspaceOptions.type === 'Collections') { | ||
| // Fetching extra metadata for database should not block tab opening | ||
| void dispatch(fetchDatabaseInfo(workspaceOptions)); |
Anemy
reviewed
Jan 30, 2025
gribnoysup
approved these changes
Jan 31, 2025
Comment on lines
+117
to
+119
| isTimeSeries: collection.isTimeSeries, | ||
| isReadonly: collection.readonly ?? collection.isView, | ||
| sourceName: collection.sourceName, |
Collaborator
There was a problem hiding this comment.
For case like this I'd probably prefer to either have a dedicated action or subscribe to all fields you're updating, otherwise you're listening here to one thing, but updating others, it's a but confusing to navigate. Taking into account we're going to refactor this, that's fine for now
Collaborator
Author
There was a problem hiding this comment.
great point. with refactor in mind, i'll merge this for now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Light Mode
Dark Mode
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes