feat(schema): run schema analysis with secondaryPreferred when read pref not set COMPASS-8854 #6665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paula-stacho
approved these changes
Jan 29, 2025
Collaborator
paula-stacho
left a comment
paula-stacho
left a comment
There was a problem hiding this comment.
You forgot to add 'mongodb-connection-string-url' to dependencies, but otherwise neat! 🎉
gribnoysup
reviewed
Jan 29, 2025
Comment on lines
217
to
221
| function isReadPreferenceSet(connectionString: string): boolean { | ||
| return !!new ConnectionString(connectionString).searchParams.get( | ||
| 'readPreference' | ||
| ); | ||
| } |
Collaborator
There was a problem hiding this comment.
Not a strong preference, but I feel like dataService might be a better place for this logic, it feels out of the domain of the schema plugin to know how to extract connection options from the connection info string.
Maybe we can make this an interface on the sample method? Something like fallbackReadPreference or defaultReadPreference option that we can pass to the method and will be only applied by the sample method using the same logic you implemented here? After all dataService is there to abstract away some parts of interacting with the driver for feature code
gribnoysup
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-8854
https://www.mongodb.com/docs/manual/core/read-preference/