fix: sign the windows setup .exe COMPASS-8945 COMPASS-8950 #6709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
added
no release notes
addaleax
approved these changes
Feb 11, 2025
lerouxb
changed the title
lerouxb
changed the title
lerouxb
force-pushed
the
log-checksums-before-after-signing
branch
from
40e6372 to
7e16bc0
Compare
lerouxb
changed the title
lerouxb
changed the title
lerouxb
force-pushed
the
log-checksums-before-after-signing
branch
from
0817504 to
3890616
Compare
lerouxb
commented
Feb 12, 2025
| "@mongodb-js/my-queries-storage": "^0.22.0", | ||
| "@mongodb-js/prettier-config-compass": "^1.2.0", | ||
| "@mongodb-js/sbom-tools": "^0.7.0", | ||
| "@mongodb-js/signing-utils": "^0.3.7", |
Contributor
Author
There was a problem hiding this comment.
So the bug was that signtool.go is doing node -e 'require("@mongodb-js/signing-utils")' from the packages/compass folder and that node module doesn't exist there.
In the past it probably worked because the dep was hoisted and then it broke because now it is not.
Contributor
Author
There was a problem hiding this comment.
I think doing something like npx run sign -w @mongodb-js/hadron-build -- path-to-file from signtool.go would be a cleaner fix. I'll try that in a follow-up.
lerouxb
changed the title
lerouxb
changed the title
lerouxb
added
release notes
and removed
no-title-validation
lerouxb
commented
Feb 12, 2025
| if err != nil { | ||
| fmt.Println("Error signing the file") | ||
| fmt.Printf("%s\n", stdoutStderr) | ||
| log.Println(err) |
Contributor
Author
There was a problem hiding this comment.
Ideally this would be log.fatal(err) but then we don't see any of the logging and electron winstaller throws a huge error, none of which is helpful. Maybe it doesn't flush its subprocess's output? I'm not sure.
gribnoysup
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.