fix(deps): bump electron to 33.4.2 to resolve vuln COMPASS-9057

[paula-stacho]

Description

Created by the update-electron script.
Note: Upgrades major version. There are two breaking changes in https://github.com/electron/electron/releases/tag/v33.0.0

• Deprecated usage of textured BrowserWindow type option on macOS. -- don't see this being used
• Custom protocol URLs that use Windows file paths will no longer work correctly with the deprecated protocol.registerFileProtocol and the baseURLForDataURL property on BrowserWindow.loadURL, WebContents.loadURL, and .loadURL. -- again, I don't see any custom protocols (we only use window.loadUrl for rendererPath and use BrowserWindow.loadURL for electron proxy)

Checklist

• New tests and/or benchmarks are included
• Documentation is changed or added
• I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

• Bugfix
• New feature
• Dependency update
• Misc

Open Questions

Dependents

Types of changes

• Backport Needed
• Patch (non-breaking change which fixes an issue)
• Minor (non-breaking change which adds functionality)
• Major (fix or feature that would cause existing functionality to change)

[gribnoysup]

This breaks Compass for macos 10.15 that we currently claim support for electron/electron#44270. We can't do this without a really good reason at the moment as autoupdate will download a version of Compass that will be broken for the users still on that version

[gribnoysup]

Last time when snyk suggested major update, some of the fixes were backported actually, just their db was not up to date (I linked examples here), I'd suggest to manually check if backports are not planned at all (32 is still a supported version after all) to avoid a breaking change at the moment. Unfortunately the project to deal with dropping support for 10.15 is only starting next week, so if we can avoid this breaking change, it would be better

[paula-stacho]

Last time when snyk suggested major update, some of the fixes were backported actually, just their db was not up to date (I linked examples here), I'd suggest to manually check if backports are not planned at all (32 is still a supported version after all) to avoid a breaking change at the moment. Unfortunately the project to deal with dropping support for 10.15 is only starting next week, so if we can avoid this breaking change, it would be better

I see 👀 . Checked again today, there is a fresh 32 with the backports https://github.com/electron/electron/releases/tag/v32.3.2. Will reopen the other PR and add exceptions for Snyk.