feat(schema-validation): add confirmation modal when applying rules, add explicit editing state COMPASS-8861 #6766
Conversation
…add explicit editing state
|
I'm seeing a different copy + option to not show the modal again in the designs, are we looking at the same version?
|
|
@paula-stacho I just with Misba on the designs. We might use this wording in the pr instead of whats in the designs to be more inline with other confirmation modals in Compass (save aggregation for instance). I did miss that option not to show the modal again though thanks! I'll push up a commit today. |
…variant, enable apply on non-syntax error
|
@paula-stacho I created a new ticket for the "don't show this message again" checkbox: https://jira.mongodb.org/browse/COMPASS-9076 |
paula-stacho
left a comment
paula-stacho
left a comment
There was a problem hiding this comment.
Look great! Thanks for fixing additional details!
This is most of COMPASS-8861, I'd like to do the toasts separately as they can be in a separate pr from this work without any conflicts.
Designs: https://www.figma.com/design/CBHJriBQZ2qxMxtnXFgDxJ/EXPO-3174-%3A-Export-Schema-%2B-Validation-Detection?node-id=1309-40813&t=ouDByoHIQallPTXr-1
Screenshots
We could refactor the store here to have fewer reducers to simplify some of the actions here. Probably not worth making part of this work, but something that is on the mind with these changes. Removing some of the debouncing and cleaning up the fetching of existing validation would be nice as well.