Skip to content

Conversation

@Anemy
Copy link
Member

@Anemy Anemy commented Mar 4, 2025

Last part of COMPASS-8861

In the designs only the success is shown: https://www.figma.com/design/CBHJriBQZ2qxMxtnXFgDxJ/EXPO-3174-%3A-Export-Schema-%2B-Validation-Detection?node-id=1304-36815&t=ouDByoHIQallPTXr-1
Opening as a draft as I want to clear up if we want all 3 of these toasts, some of them, or none at all. For errors it can be loud, and we also show the error in the UI:

Screenshot 2025-03-03 at 8 41 46 PM

The success toast is a bit outside of the user's flow, as the updateCollection command that's run is almost always instant. I did find it to be a nice affirmation though.
There isn't currently any way that visually indicates that the validation rule update is in progress, so I do think that toast could be nice. That being said we should also disable the update button until the response is in. I looked into it and found myself wanting to refactor the state and the modules a bit to make them easier to work with and more inline with the rest of Compass. I'll hold off on making changes there until I get to chat about it with folks and we get the deliverables of the project out of the way.

@Anemy Anemy added the no release notes Fix or feature not for release notes label Mar 4, 2025
@evergreen-ci-prod
Copy link

There is an existing patch(es) for this commit SHA:

Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'.

@Anemy
Copy link
Member Author

Anemy commented Mar 4, 2025

Chatted with Misba, we're going to only have a success toast. We do want an in progress button state, that will require some extra work though so I'll break that into its own ticket. I'll do it in a new pr.

@Anemy Anemy closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants