Skip to content

Conversation

@paula-stacho
Copy link
Collaborator

@paula-stacho paula-stacho commented Mar 6, 2025

Description

Behind enableExportSchema feature flag. Error messages aligned with schema analysis (advice for timeout and high complexity, same wording except the operation name).

Screenshot 2025-03-07 at 13 45 22 Screenshot 2025-03-07 at 13 45 36

Todo:

  • match error messages to the ones in schema tab
  • add tests

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the feat label Mar 6, 2025
@paula-stacho paula-stacho added the feature flagged PRs labeled with this label will not be included in the release notes of the next release label Mar 6, 2025
@paula-stacho paula-stacho removed the wip label Mar 7, 2025
@paula-stacho paula-stacho marked this pull request as ready for review March 7, 2025 15:05
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left one suggestion on a better error message on max timeout

@paula-stacho paula-stacho merged commit c398ee6 into main Mar 10, 2025
55 checks passed
@paula-stacho paula-stacho deleted the COMPASS-8859 branch March 10, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat feature flagged PRs labeled with this label will not be included in the release notes of the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants