feat: validation errors on import COMPAS-8867 #6795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paula-stacho
added
the
feature flagged
Anemy
approved these changes
Mar 13, 2025
Member
Anemy
left a comment
Anemy
left a comment
There was a problem hiding this comment.
lgtm! Left one UX suggestion on toast clickability/hiding.
| {err?.message} | ||
| {showErrorDetails && ( | ||
| <Link | ||
| onClick={showErrorDetails} |
Member
There was a problem hiding this comment.
Can we close those toast when the user clicks to see the error? We currently will keep showing the toast when the modal is open, but the dismiss is not clickable as I the modal is capturing all of the clicks. I think there's a similar issue with the toast on connectivity issues, not the end of the world if it's not easily feasible, a nice to have.
paula-stacho
added a commit
that referenced
this pull request
Mar 14, 2025
paula-stacho
added a commit
that referenced
this pull request
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding error details for documents import.
First case: Not aborting on errors.
Details are available in the log file. This was almost working already, but there was a misnomer -
errorInfovserrInfo.Second case: Aborting on error.
Users can view the error details in a modal window (similar to the other cases).
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes