-
Notifications
You must be signed in to change notification settings - Fork 246
feat: show validation error details COMPASS-8864 COMPASS-8867 COMPASS-8865 #6797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9ac047e to
b574c1e
Compare
f6402c1 to
dcfac20
Compare
923c030 to
2970a30
Compare
daf64ca to
11cbc9a
Compare
Anemy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The insert document modal has been a place that has a lot of edge conditions, happy to see it moving to a functional component and becoming a bit easier to work with. Nice test adds and the error details are a good feature. Left a couple small questions and one or two suggestions.
packages/compass-crud/src/components/insert-document-dialog.tsx
Outdated
Show resolved
Hide resolved
packages/compass-crud/src/components/insert-document-dialog.tsx
Outdated
Show resolved
Hide resolved
e3795a9 to
2dc5a54
Compare
Description
Combines the error details on insert, import and single update (the rest has been de-prioritized, but we might bring it in if we have extra time this week).
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes