feat(release): dual write release artifacts to new bucket COMPASS-9160 #6801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drichmdb
force-pushed
the
new-downloads-bucket
branch
2 times, most recently
from
d9b140c to
3935446
Compare
drichmdb
changed the title
drichmdb
changed the title
drichmdb
changed the title
drichmdb
changed the title
This commit adjusts Compass to write release artifacts to a new S3 bucket. Eventually the old bucket will be removed after we have confirmed that we can serve artifacts from the new bucket. We also use assume role to access this bucket instead of static credentials.
drichmdb
force-pushed
the
new-downloads-bucket
branch
from
3935446 to
782b4b3
Compare
Contributor
|
Just in case you're not aware (before any buckets go away) these assets are also used by things like the auto update server: https://github.com/10gen/compass-mongodb-com/blob/master/src/utils.js |
Contributor
|
Oh and I believe the publish step in CI is skipped on PRs, so we'd likely only be able to test this when doing a beta. |
Contributor
Author
|
@lerouxb I was definitely not aware of the auto-updater, thank you for pointing that out! I see it's using a direct S3 URL, so we'll have to update that and coordinate on when cutting over makes sense. |
lerouxb
approved these changes
Mar 26, 2025
Contributor
lerouxb
left a comment
lerouxb
left a comment
There was a problem hiding this comment.
Looks good. Like I mentioned this code might only run when doing a beta/stable release, though. But if a beta fails we should have enough context to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts Compass to write release artifacts to a new S3 bucket.
Eventually the old bucket will be removed after we have confirmed that we
can serve artifacts from the new bucket. We also use assume role to access
this bucket instead of static credentials.