fix(compass-schema): sticky copy button COMPASS-9141 #6804
Conversation
paula-stacho
added
the
feature flagged
| }); | ||
|
|
||
| const codeStyles = css({ | ||
| '& .cm-editor': { |
There was a problem hiding this comment.
It does strike me as not the best practice to be overriding the internal styles of the editor here. Ideally compass-schema shouldn't know we're even using code mirror under the hood. Since we're already doing it, I think fine as is, but something we should probably avoid.
There was a problem hiding this comment.
I was the one who introduced this too 🤦
Looks like we do it in a few other places in Compass also.
There was a problem hiding this comment.
You're right, we could've just added some parameters that the compass component would translate into these styles. We don't and we even named the component <CodeMirrorMultilineEditor />, so I think the ship has sailed 😅 . And by sailed I mean I don't think we have time to fix that atm 🙈
There was a problem hiding this comment.
... or you can just set maxLines on the component to 15 (which matches the math here) and it will already make the editor limited in size and the action buttons sticky with no extra styles and class names referring to the component internals 🙂
Description
Fixing the styles for code editor on export schema modal
Before:
The whole editor scrolls, so the actions get hidden down the line.
After:
Only content of the editor scrolls.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes