Skip to content

fix: allow deleting updatemany queries COMPASS-9121 #6817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

fix: allow deleting updatemany queries COMPASS-9121 #6817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/compass-saved-aggregations-queries/src/stores/delete-item.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,11 @@ export const confirmDeleteItem = (
undefined // this event is connection scoped when triggered from the aggregation or query screen
);

if (item.type === 'query') {
await queryStorage?.delete(item.id);
} else {
if (item.type === 'aggregation') {
await pipelineStorage?.delete(item.id);
} else {
// query or updatemany
await queryStorage?.delete(item.id);
}

dispatch({ type: ActionTypes.DeleteItemConfirm, id: item.id });
Expand Down
7 changes: 4 additions & 3 deletions packages/compass-saved-aggregations-queries/src/stores/edit-item.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,14 @@ export const updateItem =
return;
}

if (item.type === 'query') {
if (item.type === 'aggregation') {
await pipelineStorage?.updateAttributes(id, attributes);
} else {
// query or updatemany
await queryStorage?.updateAttributes(id, {
_name: attributes.name,
_dateModified: new Date(),
});
} else {
await pipelineStorage?.updateAttributes(id, attributes);
}

dispatch({
Expand Down
3 changes: 2 additions & 1 deletion packages/compass-saved-aggregations-queries/src/stores/open-item.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,8 @@ export const openSelectedItem =
await pipelineStorage?.updateAttributes(id, {
namespace: newNamespace,
});
} else if (selectedItem.type === 'query') {
} else {
// query or updatemany
await queryStorage?.updateAttributes(id, { _ns: newNamespace });
}
}
Expand Down
Loading