Skip to content

fix: remove readPreferenceTags for database&collection lookups if the cluster is sharded and readPreferenceTags was set COMPASS-9111 #6818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 26, 2025
Merged

fix: remove readPreferenceTags for database&collection lookups if the cluster is sharded and readPreferenceTags was set COMPASS-9111 #6818

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c4d460
set readPreference=secondaryPreferred for database&collection lookups…
lerouxb Mar 25, 2025
f1d0439
rather send a read preference with just the tags removed
lerouxb Mar 25, 2025
1b6ec1d
send everything as options
lerouxb Mar 25, 2025
7be4c09
Add a test plus a comment
lerouxb Mar 26, 2025
acb74e7
Merge branch 'main' into no-tags-dbs-collections
lerouxb Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 42 additions & 3 deletions packages/data-service/src/data-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ import type {
SearchIndexDescription,
ReadPreferenceMode,
} from 'mongodb';
import { ReadPreference } from 'mongodb';
import ConnectionStringUrl from 'mongodb-connection-string-url';
import parseNamespace from 'mongodb-ns';
import type {
Expand Down Expand Up @@ -133,6 +134,26 @@ function isReadPreferenceSet(connectionString: string): boolean {
);
}

function readPreferenceWithoutTags(readPreference: ReadPreference) {
return new ReadPreference(readPreference.mode, undefined, {
maxStalenessSeconds: readPreference.maxStalenessSeconds,
hedge: readPreference.hedge,
});
}

function maybeOverrideReadPreference(
isMongos: boolean,
readPreference?: ReadPreference
): {
readPreference?: ReadPreference;
} {
if (isMongos && readPreference?.tags) {
return { readPreference: readPreferenceWithoutTags(readPreference) };
}

return {};
}

let id = 0;

type ClientType = 'CRUD' | 'META';
Expand Down Expand Up @@ -1264,7 +1285,13 @@ class DataServiceImpl extends WithLogContext implements DataService {
try {
const cursor = this._database(databaseName, 'CRUD').listCollections(
filter,
{ nameOnly }
{
nameOnly,
...maybeOverrideReadPreference(
this.isMongos(),
this._crudClient?.readPreference
),
}
);
// Iterate instead of using .toArray() so we can emit
// collection info update events as they come in.
Expand Down Expand Up @@ -1399,7 +1426,13 @@ class DataServiceImpl extends WithLogContext implements DataService {
} as {
listDatabases: 1;
},
{ enableUtf8Validation: false }
{
enableUtf8Validation: false,
...maybeOverrideReadPreference(
this.isMongos(),
this._crudClient?.readPreference
),
}
);
return databases.map((x) => ({
...x,
Expand Down Expand Up @@ -2542,7 +2575,13 @@ class DataServiceImpl extends WithLogContext implements DataService {
const stats = await runCommand(
db,
{ dbStats: 1 },
{ enableUtf8Validation: false }
{
enableUtf8Validation: false,
...maybeOverrideReadPreference(
this.isMongos(),
this._crudClient?.readPreference
),
}
);
const normalized = adaptDatabaseInfo(stats);
return { name, ...normalized };
Expand Down
Loading