Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import React from 'react';
import { render, screen } from '@mongodb-js/testing-library-compass';
import CreateIndexModalHeader from './create-index-modal-header';
import { expect } from 'chai';

describe('CreateIndexModalHeader', () => {
it('renders the modal title', () => {
render(<CreateIndexModalHeader />);
const title = screen.getByTestId('create-index-modal-header-title');

expect(title.textContent).to.be.equal('Create Index');
});

it('renders the subtitle text', () => {
render(<CreateIndexModalHeader />);
const subtitle = screen.getByTestId('create-index-modal-header-subtitle');
expect(subtitle).to.exist;
});

it('renders the link to the Index Strategies Documentation', () => {
render(<CreateIndexModalHeader />);
const link = screen.getByRole('link', {
name: /Index Strategies Documentation/i,
});
expect(link).to.exist;
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import {
H3,
Body,
spacing,
css,
palette,
Link,
} from '@mongodb-js/compass-components';
import React from 'react';

const headerStyle = css({
padding: spacing[800],
paddingBottom: 0,
});

const subtitleStyle = css({
color: palette.gray.dark1,
});

const CreateIndexModalHeader = () => {
return (
<div className={headerStyle}>
<H3 data-testid="create-index-modal-header-title">Create Index</H3>

<Body
data-testid="create-index-modal-header-subtitle"
className={subtitleStyle}
>
The best indexes for your application should consider a number of
factors, such as your data model, and the queries you use most often. To
learn more about indexing best practices, read the{' '}
<Link
href="https://docs.mongodb.com/manual/applications/indexes/"
target="_blank"
rel="noopener noreferrer"
>
Index Strategies Documentation
</Link>
.
</Body>
</div>
);
};

export default CreateIndexModalHeader;
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,12 @@ import type { RootState } from '../../modules';
import {
useTrackOnChange,
type TrackFunction,
useFireExperimentViewed,
TestName,
} from '@mongodb-js/compass-telemetry/provider';
import { useConnectionInfoRef } from '@mongodb-js/compass-connections/provider';
import { usePreference } from 'compass-preferences-model/provider';
import CreateIndexModalHeader from './create-index-modal-header';

type CreateIndexModalProps = React.ComponentProps<typeof CreateIndexForm> & {
isVisible: boolean;
Expand Down Expand Up @@ -70,13 +74,28 @@ function CreateIndexModal({
undefined
);

// @experiment Early Journey Indexes Guidance & Awareness | Jira Epic: CLOUDP-239367
const enableInIndexesGuidanceExp = usePreference('enableIndexesGuidanceExp');
const showIndexesGuidanceVariant =
usePreference('showIndexesGuidanceVariant') && enableInIndexesGuidanceExp;

useFireExperimentViewed({
testName: TestName.earlyJourneyIndexesGuidance,
shouldFire: enableInIndexesGuidanceExp && isVisible,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm understanding this wrong, should this be showIndexesGuidanceVariant and not enableInIndexesGuidanceExp?

Suggested change
shouldFire: enableInIndexesGuidanceExp && isVisible,
shouldFire: showIndexesGuidanceVariant && isVisible,

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope this should fire for when user is in the control as well so it should be enableInIndexesGuidanceExp

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we track that they're in the control then? Or is there already a way we differentiate that they are shown/not shown the new experience?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tracks if they are in the control as well, if they are in the experiment enableInIndexesGuidanceExp is true. i need to confirm once i get the latest into our mms but i think by default we have code set up to send down whether user is in the variant or control

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make things easier if we track if they're in the control or shown the experience here as some metadata for the tracking event? If it's on the mms side I suppose we don't need to since we'll be able to correlate them anyway. Feel free to resolve!

});

return (
<Modal
open={isVisible}
setOpen={onSetOpen}
data-testid="create-index-modal"
size={showIndexesGuidanceVariant ? 'large' : 'default'}
>
<ModalHeader title="Create Index" subtitle={namespace} />
{showIndexesGuidanceVariant ? (
<CreateIndexModalHeader />
) : (
<ModalHeader title="Create Index" subtitle={namespace} />
)}

<ModalBody>
<CreateIndexForm namespace={namespace} {...props} />
Expand Down
21 changes: 21 additions & 0 deletions packages/compass-preferences-model/src/feature-flags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ export type FeatureFlags = {
enableRollingIndexes: boolean;
enableGlobalWrites: boolean;
enableDataModeling: boolean;
enableIndexesGuidanceExp: boolean;
showIndexesGuidanceVariant: boolean;
};

export const featureFlags: Required<{
Expand Down Expand Up @@ -122,4 +124,23 @@ export const featureFlags: Required<{
short: 'Design, Visualize, and Evolve your Data Model',
},
},

/**
* Feature flags for Early Journey Indexes Guidance & Awareness | Jira Epic: CLOUDP-239367
* These are passed from MMS and not editable by user
*/
enableIndexesGuidanceExp: {
stage: 'development',
description: {
short: 'Enable Indexes Guidance Experiment',
},
},

showIndexesGuidanceVariant: {
stage: 'development',
description: {
short:
'Used to check if user is in the Indexes Guidance Experiment Variant',
},
},
};
3 changes: 3 additions & 0 deletions packages/compass-telemetry/src/growth-experiments.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export enum TestName {
earlyJourneyIndexesGuidance = 'EARLY_JOURNEY_INDEXES_GUIDANCE_20250328',
}
35 changes: 35 additions & 0 deletions packages/compass-telemetry/src/provider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { createServiceLocator } from 'hadron-app-registry';
import { createTrack, type TelemetryServiceOptions } from './generic-track';
import { useLogger } from '@mongodb-js/compass-logging/provider';
import type { TrackFunction } from './types';
import { TestName } from './growth-experiments';

const noop = () => {
// noop
Expand Down Expand Up @@ -101,4 +102,38 @@ export function useTrackOnChange(
}, [...dependencies, track, options.skipOnMount]);
}

/**
* Hook that fires Experiment Viewed if user is in an experiment
*
* @param testName - The name of the experiment to track.
* @param shouldFire - A boolean indicating whether to fire the event. Defaults to true.
*
* @example
* useFireExperimentViewed({
* testName: TestName.earlyJourneyIndexesGuidance,
* shouldFire: enableInIndexesGuidanceExp ,
* });
*/
export const useFireExperimentViewed = ({
testName,
shouldFire = true,
}: {
testName: TestName;
shouldFire?: boolean;
}) => {
useTrackOnChange(
(track: TrackFunction) => {
if (!shouldFire) {
return;
}
track('Experiment Viewed', {
test_name: testName,
});
},
[shouldFire, testName],
undefined
);
};

export type { TrackFunction };
export { TestName };
8 changes: 7 additions & 1 deletion packages/compass-telemetry/src/telemetry-events.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2673,6 +2673,11 @@ type SecretStorageNotAvailableEvent = CommonEvent<{
payload: Record<string, never>;
}>;

type ExperimentViewedEvent = CommonEvent<{
name: 'Experiment Viewed';
payload: { test_name: string };
}>;

export type TelemetryEvent =
| AggregationCanceledEvent
| AggregationCopiedEvent
Expand Down Expand Up @@ -2793,4 +2798,5 @@ export type TelemetryEvent =
| LargestContentfulPaintEvent
| FirstInputDelayEvent
| CumulativeLayoutShiftEvent
| TimeToFirstByteEvent;
| TimeToFirstByteEvent
| ExperimentViewedEvent;
Loading