Skip to content

fix: determine Atlas connection from connection String #6867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

fix: determine Atlas connection from connection String #6867

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f253f3
fix: determine Atlas connection from connection String
gagik Apr 15, 2025
9f4b3a3
refactor: add comment and move isAtlas inside
gagik Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/compass-connections/src/stores/connections-store-redux.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ import {
import { getNotificationTriggers } from '../components/connection-status-notifications';
import { openToast, showConfirmation } from '@mongodb-js/compass-components';
import { adjustConnectionOptionsBeforeConnect } from '@mongodb-js/connection-form';
import mongodbBuildInfo, { getGenuineMongoDB } from 'mongodb-build-info';
import mongodbBuildInfo, {
getGenuineMongoDB,
isAtlas,
} from 'mongodb-build-info';
import EventEmitter from 'events';
import { showNonGenuineMongoDBWarningModal as _showNonGenuineMongoDBWarningModal } from '../components/non-genuine-connection-modal';
import ConnectionString from 'mongodb-connection-string-url';
Expand Down Expand Up @@ -1556,7 +1559,9 @@ const connectWithOptions = (
),
connectionInfo: {
id: connectionInfo.id,
isAtlas: !!connectionInfo.atlasMetadata,
isAtlas: isAtlas(
connectionInfo.connectionOptions.connectionString
),
Copy link
Collaborator

@gribnoysup gribnoysup Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be completely encapsulated inside the adjustConnectionOptionsBeforeConnect method? Is there any reason to keep this logic configurable from outside if we always want this to be applied based on the connection string?

},
defaultAppName: appName,
preferences: {
Expand Down
Loading