feat: Add UI for Start with a Query Flow CLOUDP-311785 #6881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
reviewed
Apr 23, 2025
packages/compass-indexes/src/components/create-index-form/query-flow-section.tsx
Outdated
Show resolved
Hide resolved
Anemy
reviewed
Apr 24, 2025
packages/compass-indexes/src/components/create-index-form/query-flow-section.tsx
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/create-index-form/query-flow-section.tsx
Outdated
Show resolved
Hide resolved
Anemy
reviewed
Apr 24, 2025
packages/compass-indexes/src/components/create-index-form/query-flow-section.tsx
Outdated
Show resolved
Hide resolved
Anemy
reviewed
Apr 24, 2025
packages/compass-indexes/src/components/create-index-form/query-flow-section.tsx
Outdated
Show resolved
Hide resolved
Anemy
reviewed
Apr 24, 2025
packages/compass-indexes/src/components/create-index-form/query-flow-section.tsx
Outdated
Show resolved
Hide resolved
Anemy
reviewed
Apr 24, 2025
packages/compass-indexes/src/components/create-index-form/query-flow-section.tsx
Outdated
Show resolved
Hide resolved
Anemy
reviewed
Apr 24, 2025
packages/compass-indexes/src/components/create-index-form/query-flow-section.tsx
Outdated
Show resolved
Hide resolved
Anemy
reviewed
Apr 25, 2025
| const codeEditorStyles = css({ | ||
| borderRadius: editorContainerRadius, | ||
| '& .cm-editor': { | ||
| background: `${palette.white} !important`, |
Member
There was a problem hiding this comment.
In darkMode this looks very bright:
I also think we want the border color above border: `1px solid ${palette.gray.base}`, to look a bit different in dark mode.
Here's a place in the code we change a border and background based on dark mode:
Member
There was a problem hiding this comment.
Chatted w/ Ruby, we'll address more dark mode support in a future pr.
Anemy
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added ui without functionality for the query flow
active state
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes