feat: Add covered and optimal query examples CLOUDP-311782 #6883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
reviewed
Apr 28, 2025
Member
Anemy
left a comment
Anemy
left a comment
There was a problem hiding this comment.
Looking good, left a couple questions/comments
packages/compass-indexes/src/components/create-index-form/index-flow-section.tsx
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/create-index-form/index-flow-section.tsx
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/create-index-form/index-flow-section.tsx
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/create-index-form/index-flow-section.tsx
Show resolved
Hide resolved
Anemy
reviewed
Apr 29, 2025
|
|
||
| const coveredQueriesArr = fields.map((field, index) => { | ||
| return { [field.name]: index + 1 }; | ||
| const [coveredQueriesObj, setCoveredQueriesObj] = useState<{ |
Member
There was a problem hiding this comment.
When the user changes the fields should we reset this so that they have to re-click the show covered queries button? That way we don't show them something out of date. Fine as is also, I'm mostly thinking if it's a nicer experience for the user one way.
Collaborator
Author
There was a problem hiding this comment.
https://jira.mongodb.org/browse/CLOUDP-311787 i have this ticket for polishing up all the UX for further disabled states, error states etc for everything across the modal
Anemy
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jira.mongodb.org/browse/CLOUDP-311782
Best viewed with 'hide whitespace'
Added a tooltip for when the type is not supported:
Default state:
One field:
Two fields:
Three fields:
Checklist
Motivation and Context
Types of changes