Skip to content

chore(compass-web): do not expose internal logger details to web onLog hook #6936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2025
Merged

chore(compass-web): do not expose internal logger details to web onLog hook #6936

merged 3 commits into from
May 20, 2025

Conversation

@addaleax
Copy link
Collaborator

@addaleax addaleax commented May 20, 2025

Instead, pass the processed log contents to it.

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@addaleax
chore(compass-web): do not expose internal logger details to web `onL…
7c166bb 
…og` hook

Instead, pass the processed log contents to it.
@addaleax addaleax added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label May 20, 2025
nbbeeken
nbbeeken reviewed May 20, 2025
View reviewed changes
nbbeeken
nbbeeken approved these changes May 20, 2025
View reviewed changes
Copy link
Collaborator

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@addaleax addaleax merged commit 5460f5b into main May 20, 2025
44 of 55 checks passed
@addaleax addaleax deleted the compass-web-logger-interface-1 branch May 20, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

No one assigned

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@addaleax @nbbeeken