Skip to content

feat: revert nudge back to icon on default and expand on hover CLOUDP-319356 #6940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

feat: revert nudge back to icon on default and expand on hover CLOUDP-319356 #6940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions packages/compass-components/src/components/signal-popover.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,23 +51,6 @@ describe('SignalPopover', function () {
});
});

it('should show insights badge text by default if shouldExpandBadge is true', function () {
const { rerender } = render(
<SignalPopover signals={signals[0]} shouldExpandBadge={false} />
);

// opacity: 0 means that the text will not show up
expect(screen.getByTestId('insight-badge-text').style.opacity).to.equal(
'0'
);

rerender(<SignalPopover signals={signals[0]} shouldExpandBadge={true} />);
// opacity: 1 means that the text will show up
expect(screen.getByTestId('insight-badge-text').style.opacity).to.equal(
'1'
);
});

describe('SignalHooksProvider', function () {
it('should call hooks through the signal lifecycle', function () {
const hooks: React.ComponentProps<typeof SignalHooksProvider> = {
Expand Down
9 changes: 3 additions & 6 deletions packages/compass-components/src/components/signal-popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ type SignalPopoverProps = {
darkMode?: boolean;
onPopoverOpenChange?: (open: boolean) => void;
className?: string;
shouldExpandBadge?: boolean;
};

const signalCardContentStyles = css({
Expand Down Expand Up @@ -442,7 +441,6 @@ const SignalPopover: React.FunctionComponent<SignalPopoverProps> = ({
darkMode: _darkMode,
onPopoverOpenChange: _onPopoverOpenChange,
className,
shouldExpandBadge,
}) => {
const hooks = useContext(TrackingHooksContext);
const darkMode = useDarkMode(_darkMode);
Expand All @@ -455,7 +453,6 @@ const SignalPopover: React.FunctionComponent<SignalPopoverProps> = ({
const currentSignal = signals[currentSignalIndex];
const multiSignals = signals.length > 1;
const isActive = isHovered || popoverOpen;
const shouldShowFullBadge = isActive || shouldExpandBadge;

const triggerRef = useRef<HTMLButtonElement>(null);

Expand Down Expand Up @@ -592,7 +589,7 @@ const SignalPopover: React.FunctionComponent<SignalPopoverProps> = ({
className
),
style: {
width: shouldShowFullBadge ? activeBadgeWidth : 18,
width: isActive ? activeBadgeWidth : 18,
},
ref: triggerRef,
},
Expand All @@ -611,7 +608,7 @@ const SignalPopover: React.FunctionComponent<SignalPopoverProps> = ({
size="small"
className={cx(badgeIconStyles, badgeIconCollapsedStyles)}
data-testid="insight-badge-icon"
style={{ opacity: shouldShowFullBadge ? 0 : 1 }}
style={{ opacity: isActive ? 0 : 1 }}
></Icon>
<strong
className={cx(
Expand All @@ -621,7 +618,7 @@ const SignalPopover: React.FunctionComponent<SignalPopoverProps> = ({
data-testid="insight-badge-text"
style={{
width: activeBadgeWidth,
opacity: shouldShowFullBadge ? 1 : 0,
opacity: isActive ? 1 : 0,
}}
>
{badgeLabel}
Expand Down
4 changes: 1 addition & 3 deletions packages/compass-crud/src/components/crud-toolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,7 @@ const CrudToolbar: React.FunctionComponent<CrudToolbarProps> = ({
onClick={onDeleteButtonClicked}
></DeleteMenu>
)}
{insights && (
<SignalPopover signals={insights} shouldExpandBadge={true} />
)}
{insights && <SignalPopover signals={insights} />}
</div>
<div className={toolbarRightActionStyles}>
<Select
Expand Down
Loading