chore(eslint-config): update eslint to 8 #6942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
force-pushed
the
update-eslint-to-eight
branch
from
98350eb to
7effe5d
Compare
gribnoysup
force-pushed
the
update-eslint-to-eight
branch
2 times, most recently
from
829fb02 to
aa9b731
Compare
gribnoysup
force-pushed
the
update-eslint-to-eight
branch
from
aa9b731 to
8013236
Compare
gribnoysup
added
the
no-title-validation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gribnoysup
commented
May 22, 2025
| - name: Bump eslint | ||
| run: | | ||
| npm i --save eslint@8 -w @mongodb-js/eslint-config-compass |
Collaborator
Author
There was a problem hiding this comment.
I'll add more related packages here after I'm done updating them, for now it's only eslint that we can autoupdate
gribnoysup
commented
May 22, 2025
Collaborator
Author
There was a problem hiding this comment.
eslint bump caused a bunch of related minor / patch bumps with it, hence the high LoC change here
gribnoysup
commented
May 22, 2025
| } | ||
| if (this.isSharded) { | ||
| for (const shard of this.executionStats?.executionStages?.shards) { | ||
| for (const shard of this.executionStats?.executionStages?.shards ?? []) { |
Collaborator
Author
There was a problem hiding this comment.
The only potential bug that got spotted by that change (good catch though)
mabaasit
reviewed
May 22, 2025
.github/workflows/update-eslint.yaml
Outdated
| @@ -0,0 +1,53 @@ | |||
| name: Update electron | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| name: Update electron | |
| name: Update eslint |
.github/workflows/update-eslint.yaml
Outdated
| with: | ||
| token: ${{ steps.app-token.outputs.token }} | ||
| commit-message: 'chore(deps): update eslint' | ||
| branch: ci/update-electron |
Collaborator
There was a problem hiding this comment.
this should also be different?
Collaborator
Author
There was a problem hiding this comment.
Yep, thanks for spotting!
addaleax
reviewed
May 22, 2025
mabaasit
approved these changes
May 22, 2025
addaleax
approved these changes
May 22, 2025
gribnoysup
commented
May 22, 2025
…integration can resolve them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm splitting #6833 into smaller, separately mergeable parts. This one only updates eslint to 8 (prereq for bumping tslint and rulesets) the fixes the only check that this affected