Skip to content

Conversation

@paula-stacho
Copy link
Collaborator

@paula-stacho paula-stacho commented May 21, 2025

Description

This is for us to see if the old uuids are still being used.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the fix label May 21, 2025
Copy link
Collaborator

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are tracking this for crud view, this should be added in the crud plugin. Compass components are by design foundational components detached from compass business logic and anything that requires a service

@paula-stacho paula-stacho added the no release notes Fix or feature not for release notes label May 22, 2025
@paula-stacho paula-stacho marked this pull request as ready for review May 22, 2025 13:22
Copy link
Collaborator

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would maybe suggest to pay close attention when we release this to make sure that we're not submitting way too many of those events. This happened a couple of times unintentially and something we are potentially submitting every time the docs are fetched can also cause this I think

}
if (uuidSubtype4Count > 0) {
track('UUID Encountered', { subtype: 4, count: uuidSubtype4Count });
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could/should these be a single event that submits two different counts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can ask analytics what is easier for them

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like they have no preference. I don't expect many collections to have both types so I don't think this will cause much overload in terms of event count, so I'm merging like this.

@paula-stacho paula-stacho merged commit 4c530c5 into main May 28, 2025
56 checks passed
@paula-stacho paula-stacho deleted the COMPASS-9359 branch May 28, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants