fix: track usage of uuid subtype 3 vs 4 COMPASS-9359#6943
Conversation
gribnoysup
left a comment
There was a problem hiding this comment.
If we are tracking this for crud view, this should be added in the crud plugin. Compass components are by design foundational components detached from compass business logic and anything that requires a service
1806ce2 to
2201e2f
Compare
gribnoysup
left a comment
There was a problem hiding this comment.
Looks good! I would maybe suggest to pay close attention when we release this to make sure that we're not submitting way too many of those events. This happened a couple of times unintentially and something we are potentially submitting every time the docs are fetched can also cause this I think
| } | ||
| if (uuidSubtype4Count > 0) { | ||
| track('UUID Encountered', { subtype: 4, count: uuidSubtype4Count }); | ||
| } |
There was a problem hiding this comment.
Could/should these be a single event that submits two different counts?
There was a problem hiding this comment.
I can ask analytics what is easier for them
There was a problem hiding this comment.
looks like they have no preference. I don't expect many collections to have both types so I don't think this will cause much overload in terms of event count, so I'm merging like this.
2201e2f to
bcf88a6
Compare
Description
This is for us to see if the old uuids are still being used.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes