feat: lastModified and db for diagram list COMPASS-9398

[paula-stacho]

Description

Note: I made the cards a bit smaller than the designs, they looked too empty with only the db.

Overloads confusion

Hooks can't be called conditionally, so I made the hook useFormattedDate hook accept optional value. In that case the return type is of course optional too. This is represented with function overload. Unfortunately, the overloaded type is getting lost somewhere in the exports/imports, so in the end there is only one function signature.

Update:

I figured out what works - to repeat the overload signature. Looks like the last one is not transferred. I am still confused.

Checklist

• New tests and/or benchmarks are included
• Documentation is changed or added
• If this change updates the UI, screenshots/videos are added and a design review is requested
• I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

• Bugfix
• New feature
• Dependency update
• Misc

Open Questions

Dependents

Types of changes

• Backport Needed
• Patch (non-breaking change which fixes an issue)
• Minor (non-breaking change which adds functionality)
• Major (fix or feature that would cause existing functionality to change)

[gribnoysup]

I think when we usually refer to last modified we specifically mean when the file was saved by the storage, wouldn't it be easier to just write this value as part of the store logic instead of recalculating it here all the time?

[paula-stacho]

Yeah might be. Following the tech design here. We could achieve the same if we always save the last edit's timestamp also on the top level. But I'm actually not sure if lastModified should work like this with the undo. Shouldn't undo also count as modification? In that case we definitely need to store this. cc @Anemy - sorry that I didn't notice this when reviewing the design

[gribnoysup]

You also have a case of changing the name which counts as modification I think. Applying undo might also get confusing if we just use the timestamps (like imaging undoing to something that was timestamped a long time ago and the item that you might expect at the top is not at the bottom of the list). I really don't think we want to bind stored file modification action to edits themselves

[paula-stacho]

Updated. I didn't remove the timestamp on edits, even though I'm not sure we need that one.

[paula-stacho]

Note: If you had saved diagrams before you'll probably see errors because they miss the new fields. Just ignore and create new diagrams.

[Anemy]

Saving the last modified intentionally instead of relying on the edit timestamps sounds good 👍