-
Notifications
You must be signed in to change notification settings - Fork 247
feat: Implement dark mode for create index modal in early journey variant CLOUDP-313986 #6972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fca5e6f to
28fbde8
Compare
| className={codeEditorStyles} | ||
| className={cx( | ||
| codeEditorStyles, | ||
| !darkMode && lightModeCodeEditorStyles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case, i found it easier to default to the component's existing dark mode styles rather than apply new dark mode styling
| className={indexSuggestionsLoaderStyles} | ||
| className={cx( | ||
| indexSuggestionsLoaderStyles, | ||
| !darkMode && indexSuggestionsLoaderLightStyles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Anemy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the subtitle color as well as the border color for the input and covered queries areas?

For border color in darkmode we usually use palette.gray.dark2
https://github.com/mongodb-js/compass/blob/205e0d95f012defc99454d79265b1d4055f29036/packages/compass-aggregations/src/components/pipeline-toolbar/index.tsx#L31C16-L31C34
the design for border color is color.border.primary though https://www.figma.com/design/pFjIikzky8ACkISabtvhrH/CLOUDP-239367--Index-Guidance?node-id=1809-14262&t=VPtVMoJP2laSaWej-0 |
|
@rubydong We might want to check with design. I'm seeing two different border colors in those designs: the |
good eye and ty for calling this out, @Anemy! i think it was intentional by design to have two different border colors, as this is also the case for light mode. i'll verify with them though |
confirmed with design that there should be distinct border colors for input vs output. made updates and attached a new screencast |
Anemy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!

Description
Update the styling of Create Index Modal components to handle dark/light theming
https://jira.mongodb.org/browse/CLOUDP-313986
Before
before.mov
After
<! --- https://github.com/user-attachments/assets/65052219-c266-47ce-be54-56da47066b09 -->
Screen.Recording.2025-06-03.at.6.29.51.PM.mov
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes