Skip to content

fix: don't override editor background colours in darkmode COMPASS-9248 COMPASS-9247 #6993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025
+4 −8
Merged

fix: don't override editor background colours in darkmode COMPASS-9248 COMPASS-9247 #6993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bd847b
don't override the stage editor container background colour in darkmode
lerouxb Jun 10, 2025
43c9b60
remove the extra background on the focus editor
lerouxb Jun 10, 2025
115fd15
set the code editor in the json view dark mode to be the same colour …
lerouxb Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/compass-aggregations/src/components/focus-mode/focus-mode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,7 @@ const editorAreaBaseStyles = css({
paddingTop: spacing[600],
});

const editorAreaDarkStyles = css({
backgroundColor: palette.gray.dark4,
});
const editorAreaDarkStyles = css({});

const editorAreaLightStyles = css({
backgroundColor: palette.gray.light3,
Expand Down
4 changes: 1 addition & 3 deletions packages/compass-aggregations/src/components/stage-editor/stage-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ const editorContainerStyles = css({
height: '100%',
});

const editorContainerStylesDark = css({
background: palette.gray.dark4,
});
const editorContainerStylesDark = css({});

const editorContainerStylesLight = css({
background: palette.gray.light3,
Expand Down
4 changes: 2 additions & 2 deletions packages/compass-crud/src/components/json-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ const editorStyles = css({

const editorDarkModeStyles = css({
'& .cm-editor': {
backgroundColor: `${palette.gray.dark4} !important`,
backgroundColor: `${palette.black} !important`,
},
'& .cm-gutters': {
backgroundColor: `${palette.gray.dark4} !important`,
backgroundColor: `${palette.black} !important`,
},
});

Expand Down
Loading