feat(compass-crud): add right click menus for the CRUD toolbar COMPASS-9388 #6996
Conversation
gagik
force-pushed
the
gagik/collection-tab-top
branch
3 times, most recently
from
4c41c51 to
6d11d98
Compare
| () => querySkip || queryLimit, | ||
| [querySkip, queryLimit] | ||
| ); | ||
| const [allDocumentsExpanded, setAllDocumentsExpanded] = useState(false); |
There was a problem hiding this comment.
this isn't necessarily an accurate reflection of whether or not all documents are expanded but for this usecase I think it will work well.
There was a problem hiding this comment.
Not a blocker, but that's kind of a reason why everywhere in UI we just show both as separate options and don't try to make the behavior work like a toggle. Examples from CRUD and aggregation builder:
There was a problem hiding this comment.
Hm yeah, that does seem to fit more usecases better, i.e. one may want to go from partially manually expandeed => collapse all or expand all.
On one hand it'd be good to keep context menu items minimal but we have menus with a lot more so it's not a problem yet so I'm open to always showing both as well.
kraenhansen
force-pushed
the
gagik/collection-tab
branch
from
0626649 to
b527b6e
Compare
kraenhansen
force-pushed
the
gagik/collection-tab-top
branch
from
d992165 to
32e65fd
Compare
kraenhansen
force-pushed
the
gagik/collection-tab
branch
from
9a53b65 to
ac8572d
Compare
kraenhansen
force-pushed
the
gagik/collection-tab-top
branch
from
32e65fd to
817a426
Compare
kraenhansen
force-pushed
the
gagik/collection-tab-top
branch
from
817a426 to
030b3dc
Compare
kraenhansen
changed the title
| () => querySkip || queryLimit, | ||
| [querySkip, queryLimit] | ||
| ); | ||
| const [allDocumentsExpanded, setAllDocumentsExpanded] = useState(false); |
There was a problem hiding this comment.
Not a blocker, but that's kind of a reason why everywhere in UI we just show both as separate options and don't try to make the behavior work like a toggle. Examples from CRUD and aggregation builder:
gagik
force-pushed
the
gagik/collection-tab-top
branch
from
9a33e97 to
ab075e3
Compare
Toolbar