Skip to content

chore(eslint): re-enable no-unsafe-enum-comparison COMPASS-9459 #7022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

chore(eslint): re-enable no-unsafe-enum-comparison COMPASS-9459 #7022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eb6820
chore(eslint): re-enable no-unsafe-enum-comparison
gribnoysup Jun 13, 2025
f19e097
Merge remote-tracking branch 'origin/main' into eslint-enable-no-unsa…
gribnoysup Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion configs/eslint-config-compass/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ const extraTsRules = {
'@typescript-eslint/unbound-method': 'warn',
'@typescript-eslint/no-duplicate-type-constituents': 'warn',
'@typescript-eslint/no-unsafe-declaration-merging': 'warn',
'@typescript-eslint/no-unsafe-enum-comparison': 'warn',
};

const tsRules = {
Expand Down
2 changes: 1 addition & 1 deletion packages/compass-global-writes/src/components/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ function ShardingStateView({
return <IncompleteShardingSetup />;
}

if (shardingStatus === ShardingStatuses.LOADING_ERROR) {
if (shardingStatus === String(ShardingStatuses.LOADING_ERROR)) {
return <LoadingError />;
}

Expand Down
4 changes: 2 additions & 2 deletions packages/compass-web/polyfills/net/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,12 @@ class Socket extends Duplex {

decodeMessageWithTypeByte(message: Uint8Array) {
const typeByte = message[0];
if (typeByte === MESSAGE_TYPE.JSON) {
if (typeByte === Number(MESSAGE_TYPE.JSON)) {
const jsonBytes = message.subarray(1);
const textDecoder = new TextDecoder('utf-8');
const jsonStr = textDecoder.decode(jsonBytes);
return JSON.parse(jsonStr);
} else if (typeByte === MESSAGE_TYPE.BINARY) {
} else if (typeByte === Number(MESSAGE_TYPE.BINARY)) {
return message.subarray(1);
} else {
// eslint-disable-next-line no-console
Expand Down
2 changes: 1 addition & 1 deletion packages/connection-form/src/components/advanced-options-tabs/general-tab/scheme-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function SchemeInput({
(event: React.ChangeEvent<HTMLInputElement>) => {
updateConnectionFormField({
type: 'update-connection-scheme',
isSrv: event.target.value === MONGODB_SCHEME.MONGODB_SRV,
isSrv: event.target.value === String(MONGODB_SCHEME.MONGODB_SRV),
});
},
[updateConnectionFormField]
Expand Down