Skip to content

chore(crud): explicitly not await for store actions in render #7024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

chore(crud): explicitly not await for store actions in render #7024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/compass-crud/src/components/editable-document.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ class EditableDocument extends React.Component<
const clonedDoc = this.props.doc.generateObject({
excludeInternalFields: true,
});
this.props.openInsertDocumentDialog?.(clonedDoc, true);
void this.props.openInsertDocumentDialog?.(clonedDoc, true);
}

/**
Expand Down Expand Up @@ -267,13 +267,13 @@ class EditableDocument extends React.Component<
deleting={this.state.deleting}
onUpdate={(force) => {
if (force) {
this.props.replaceDocument?.(this.props.doc);
void this.props.replaceDocument?.(this.props.doc);
} else {
this.props.updateDocument?.(this.props.doc);
void this.props.updateDocument?.(this.props.doc);
}
}}
onDelete={() => {
this.props.removeDocument?.(this.props.doc);
void this.props.removeDocument?.(this.props.doc);
}}
onCancel={() => {
this.handleCancel();
Expand Down
6 changes: 3 additions & 3 deletions packages/compass-crud/src/components/json-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ const JSONEditor: React.FunctionComponent<JSONEditorProps> = ({
const clonedDoc = doc.generateObject({
excludeInternalFields: true,
});
openInsertDocumentDialog?.(clonedDoc, true);
void openInsertDocumentDialog?.(clonedDoc, true);
}, [doc, openInsertDocumentDialog]);

const onChange = useCallback((value: string) => {
Expand Down Expand Up @@ -137,7 +137,7 @@ const JSONEditor: React.FunctionComponent<JSONEditorProps> = ({

const onUpdate = useCallback(() => {
doc.apply(HadronDocument.FromEJSON(value || ''));
replaceDocument?.(doc);
void replaceDocument?.(doc);
}, [doc, replaceDocument, value]);

const onEditingFinished = useCallback(() => {
Expand All @@ -153,7 +153,7 @@ const JSONEditor: React.FunctionComponent<JSONEditorProps> = ({
}, []);

const onDelete = useCallback(() => {
removeDocument?.(doc);
void removeDocument?.(doc);
}, [doc, removeDocument]);

const onDeletionFinished = useCallback(() => {
Expand Down
2 changes: 1 addition & 1 deletion packages/compass-crud/src/components/table-view/document-table-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ class DocumentTableView extends React.Component<DocumentTableViewProps> {
const clonedDoc = hadronDocument.generateObject({
excludeInternalFields: true,
});
this.props.openInsertDocumentDialog?.(clonedDoc, true);
void this.props.openInsertDocumentDialog?.(clonedDoc, true);
};

/**
Expand Down
6 changes: 3 additions & 3 deletions packages/compass-crud/src/components/table-view/full-width-cell-renderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,14 @@ class FullWidthCellRenderer extends React.Component<
onUpdate={(force) => {
this.props.api.stopEditing();
if (force) {
this.props.replaceDocument(this.doc);
void this.props.replaceDocument(this.doc);
} else {
this.props.updateDocument(this.doc);
void this.props.updateDocument(this.doc);
}
}}
onDelete={() => {
this.props.api.stopEditing();
this.props.removeDocument(this.doc);
void this.props.removeDocument(this.doc);
}}
onCancel={() => {
if (this.state.mode === 'editing') {
Expand Down
Loading