Skip to content

ci(tests): enable web tests for data modeling COMPASS-9470 #7033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 19, 2025
Merged

ci(tests): enable web tests for data modeling COMPASS-9470 #7033

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b41e159
enable web tests
mabaasit Jun 17, 2025
3371ba1
Merge branch 'main' into enable-data-modeling-test-on-cloud
mabaasit Jun 17, 2025
fa831d1
make flag writable on web
mabaasit Jun 19, 2025
9302517
cleaner check
mabaasit Jun 19, 2025
6373e5f
Merge branch 'main' into enable-data-modeling-test-on-cloud
mabaasit Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/compass-e2e-tests/helpers/test-runner-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ process.env.HADRON_DISTRIBUTION ??= context.hadronDistribution;
process.env.COMPASS_WEB_HTTP_PROXY_CLOUD_CONFIG ??=
context.atlasCloudSandboxCloudConfig ?? 'dev';

if (isTestingAtlasCloudSandbox(context)) {
if (isTestingAtlasCloudSandbox(context) || isTestingWeb()) {
Copy link
Collaborator

@gribnoysup gribnoysup Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isTestingWeb applies to both, isTestingAtlasCloudSandbox is a subset

Suggested change
if (isTestingAtlasCloudSandbox(context) || isTestingWeb()) {
if (isTestingWeb()) {

Copy link
Collaborator Author

@mabaasit mabaasit Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in 9302517

process.env.E2E_TEST_CLOUD_WEB_ENABLE_PREFERENCE_SAVING ??= 'true';
}

Expand Down
5 changes: 1 addition & 4 deletions packages/compass-e2e-tests/tests/data-modeling-tab.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {
init,
cleanup,
screenshotIfFailed,
skipForWeb,
DEFAULT_CONNECTION_NAME_1,
} from '../helpers/compass';
import type { Compass } from '../helpers/compass';
Expand Down Expand Up @@ -38,12 +37,10 @@ describe('Data Modeling tab', function () {
let browser: CompassBrowser;

before(async function () {
skipForWeb(this, 'data modeling not yet available in compass-web');

compass = await init(this.test?.fullTitle());
browser = compass.browser;
await browser.setFeature('enableDataModeling', true);
await browser.setupDefaultConnections();
await browser.setFeature('enableDataModeling', true);
});

beforeEach(async function () {
Expand Down
1 change: 1 addition & 0 deletions packages/compass-preferences-model/src/compass-web-preferences-access.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const editablePreferences: (keyof UserPreferences)[] = [
'enableGenAISampleDocumentPassingOnAtlasProject',
'enableGenAIFeaturesAtlasOrg',
'enableGenAIFeaturesAtlasProject',
'enableDataModeling',
];

export class CompassWebPreferencesAccess implements PreferencesAccess {
Expand Down