Skip to content

chore(eslint-config): re-enable no-unsafe-declaration-merging rule COMPASS-9459 #7044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

chore(eslint-config): re-enable no-unsafe-declaration-merging rule COMPASS-9459 #7044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion configs/eslint-config-compass/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const extraTsRules = {
'@typescript-eslint/no-base-to-string': 'warn',
'@typescript-eslint/unbound-method': 'warn',
'@typescript-eslint/no-duplicate-type-constituents': 'warn',
'@typescript-eslint/no-unsafe-declaration-merging': 'warn',
};

const tsRules = {
Expand Down
47 changes: 28 additions & 19 deletions packages/compass-components/src/components/guide-cue/guide-cue-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,29 +16,14 @@ export type ShowCueEventDetail = CustomEvent<{
groupId?: GroupName;
}>;

type CustomEventListenerOrEventListenerObject<E> =
| { handleEvent: (evt: E) => void }
| ((evt: E) => void);

interface GuideCueEventMap {
'show-cue': ShowCueEventDetail;
}

export interface GuideCueService extends EventTarget {
addEventListener<K extends keyof GuideCueEventMap>(
type: K,
listener: (this: GuideCueEventMap, ev: GuideCueEventMap[K]) => void
): void;
addEventListener(
type: string,
listener: EventListenerOrEventListenerObject
): void;
removeEventListener<K extends keyof GuideCueEventMap>(
type: K,
listener: (this: GuideCueEventMap, ev: GuideCueEventMap[K]) => void
): void;
removeEventListener(
type: string,
listener: EventListenerOrEventListenerObject
): void;
}

export type Cue = {
groupId?: GroupName;
step: number;
Expand Down Expand Up @@ -261,6 +246,30 @@ export class GuideCueService extends EventTarget {
return this.onNext();
}
}

addEventListener<K extends keyof GuideCueEventMap>(
type: K,
listener: CustomEventListenerOrEventListenerObject<
GuideCueEventMap[K]
> | null
): void {
return super.addEventListener(
type,
listener as EventListenerOrEventListenerObject
);
}

removeEventListener<K extends keyof GuideCueEventMap>(
type: K,
listener: CustomEventListenerOrEventListenerObject<
GuideCueEventMap[K]
> | null
): void {
return super.removeEventListener(
type,
listener as EventListenerOrEventListenerObject
);
}
}

export const guideCueService = new GuideCueService(
Expand Down