refactor(storage): create an abstract QueryStorageBackend interface COMPASS-9480 #7051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
approved these changes
Jun 24, 2025
Collaborator
gribnoysup
left a comment
gribnoysup
left a comment
There was a problem hiding this comment.
One small request to make the generics stricter, otherwise looks good
|
|
||
| export abstract class CompassQueryStorage< | ||
| TSchema extends z.Schema, | ||
| TData = z.output<TSchema> |
Collaborator
There was a problem hiding this comment.
I think you should either restrict the type here or not make TData a generic at all (and I kinda thing maybe the latter even if it's a bit more verbose), schema and data are connected, so leaving the option to provide data that is not matching the schema for implementations is something we should avoid
Suggested change
| TData = z.output<TSchema> | |
| TData extends z.output<TSchema> = z.output<TSchema> |
Contributor
Author
There was a problem hiding this comment.
got it, changed thank you!
Anemy
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gearing up to have a separate Compass-Web/API-backed storage implementation that extends this new interface. Changed around some types to keep it still working for existing Compass implementation. Tested on Compass locally, seems to all be working. Waiting for CI tests to continue passing
Motivation and Context
Types of changes