Skip to content

Conversation

@paula-stacho
Copy link
Collaborator

@paula-stacho paula-stacho commented Jun 27, 2025

Description

Adds visualisation of nested fields. Also adds support for anyOf.

Arrays are displayed simply as []. This is consistent with RelationalMigrator. I thought about getting into the array item types, but with these being possibly mixed and nested it's not very straightforward and we'd need to think about how to do this. Could be a future improvement, but also it might not be worth the effort - the users will be able to see detailed schema in the sidebar later on.
For example:

  • int[], int[][], (int, string)[]
  • [int] , [[int]], [int, string]
  • array with items: int child..

Side change: I realised that there is an InlineDefinition component which fits the usecase better than Tooltip. This component is currently defined in Compass, added a note to replace with LG component in COMPASS-9496

Screenshot 2025-07-01 at 15 31 19 Screenshot 2025-07-01 at 15 30 56

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the fix label Jun 27, 2025
@paula-stacho paula-stacho added feature flagged PRs labeled with this label will not be included in the release notes of the next release wip labels Jun 27, 2025
@paula-stacho paula-stacho force-pushed the COMPASS-9488-nested branch from 6e8f0c4 to 55a8b4c Compare June 30, 2025 15:41
@paula-stacho paula-stacho force-pushed the COMPASS-9488-nested branch from 9747847 to dab4bed Compare July 1, 2025 12:57
@paula-stacho paula-stacho removed the wip label Jul 1, 2025
@paula-stacho paula-stacho marked this pull request as ready for review July 1, 2025 13:33
@paula-stacho paula-stacho requested a review from a team as a code owner July 1, 2025 13:33
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Looks good, left one testing suggestion, not a blocker, feel free to wrap it into another later pr if that's easier than re-running all the tests here.

@paula-stacho paula-stacho merged commit cb934d1 into main Jul 2, 2025
57 checks passed
@paula-stacho paula-stacho deleted the COMPASS-9488-nested branch July 2, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature flagged PRs labeled with this label will not be included in the release notes of the next release fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants