Skip to content

Conversation

@mabaasit
Copy link
Collaborator

@mabaasit mabaasit commented Jul 1, 2025

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@mabaasit mabaasit requested a review from a team as a code owner July 1, 2025 07:35
@mabaasit
Copy link
Collaborator Author

mabaasit commented Jul 1, 2025

Failing npm ci due to invalid lock file it seems, will need to look into it a bit

"version": "3.3.10",
"resolved": "https://registry.npmjs.org/@mongosh/node-runtime-worker-thread/-/node-runtime-worker-thread-3.3.10.tgz",
"version": "https://registry.npmjs.org/@mongosh/node-runtime-worker-thread/-/node-runtime-worker-thread-3.3.10.tgz",
"integrity": "sha512-kwFsBy7VQw3LVWZDd8WTp3/29lielff9W6evZqgWCYLzuiaLIO168A7KIRGuvbjYssULCb5+SrUVVYclITEXzg==",
Copy link
Collaborator Author

@mabaasit mabaasit Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know why npm install did not update the version here, but instead choose to remove it for this package (and others)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it, by removing and reinstalling these packages

@addaleax
Copy link
Collaborator

addaleax commented Jul 3, 2025

Just saw that this has conflicts with main, I'll mention that in an hour or so there will be another mongosh release out so it might make sense to just wait for that before resolving them

Comment on lines 5 to 6
"moduleResolution": "node16",
"module": "node16"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is probably due to ts-autocmplete being on typescript: 5.8

@mabaasit mabaasit marked this pull request as draft July 4, 2025 10:41
@mabaasit mabaasit marked this pull request as ready for review July 7, 2025 13:11
@mabaasit mabaasit merged commit 164bb8e into main Jul 8, 2025
83 of 84 checks passed
@mabaasit mabaasit deleted the COMPASS-9468-bump-mongosh branch July 8, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants