Skip to content

feat: Changing the sort example for 2 index fields CLOUDP-329033 #7082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025
Merged

feat: Changing the sort example for 2 index fields CLOUDP-329033 #7082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/compass-indexes/src/components/create-index-form/index-flow-section.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ describe('IndexFlowSection', () => {
`{"field1":1,"field2":{"$gt":2}}`
);
expect(optimalQueriesExamples).to.contain.text(
`{"field1":1}.sort({"field2":2})`
`{"field1":1}.sort({"field2":1})`
);
});
});
Expand Down
4 changes: 2 additions & 2 deletions packages/compass-indexes/src/components/create-index-form/index-flow-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export const generateOptimalQueries = (
const lastFieldKey = Object.keys(lastField)[0];

// If there are only two fields, we want to show two examples
// i.e. {a:1, b: {$gt:2}} and {a:1}.sort({b: 2})
// i.e. {a:1, b: {$gt:2}} and {a:1}.sort({b: 1})
if (numOfFields === 2) {
const firstField = coveredQueriesArr[0];
const firstFieldKey = Object.keys(firstField)[0];
Expand All @@ -167,7 +167,7 @@ export const generateOptimalQueries = (
<>
{`{"${firstFieldKey}":1,"${lastFieldKey}":{"$gt":2}}`}
<br />
{`{"${firstFieldKey}":1}.sort({"${lastFieldKey}":2})`}
{`{"${firstFieldKey}":1}.sort({"${lastFieldKey}":1})`}
</>
);
}
Expand Down
Loading